Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@acasta-yhliu this should fix your issue here
Summary
This PR improves the
NoiseRule/NoiseModelAPI innoise_model.py.Unified
Mapping-formaftersemantics.NoiseRule(after={"X": 0.1, "IZ": 0.05})now uses Pauli-string keys, consistent withPauliChannelandNoiseModel. Previously the mapping used stim gate-name keys ("X_ERROR","DEPOLARIZE1", etc.), which was inconsistent with every other place in the API accepting aMapping. Old gate-name keys now raise a clearValueError.Widened
clifford_1q_error/clifford_2q_error. Both now acceptfloat | PauliChannel | Mapping[str, float] | NoiseRule | None, matching the types already accepted byclifford_nq_error.Scalar depolarizing noise routes through
PauliChannel. A scalar float likeclifford_2q_error=0.01now internally constructsPauliChannel.depolarizing(k, p). This fixes a bug whereimmunize_gates=Falseon a partially-immune gate raised an error even for plain depolarizing noise, since the channel can now be correctly conditioned viaPauliChannel.conditioned_on.