Conversation
Several places independently split a SymPy polynomial into its monomial terms, and most did so incorrectly: they iterated `.args` / `make_args` without expanding, so products of sums, single-term polynomials, and raw `Poly` objects (whose `.args` also include the generators) were mishandled. Add `abstract.iter_monomial_terms`, which expands products of sums and returns the monomials of any Expr / Poly / integer uniformly, and route all call sites through it: `GroupRing.eval`, `BBCode.get_canonical_form`, `get_syndrome_subgraphs`, and `get_equivalent_toric_layout_code_data`. This also fixes bugs in `get_canonical_form`: the coefficient was multiplied once per symbol (coeff**num_symbols, wrong for non-binary fields), a `Poly` argument leaked its generators as spurious terms, and the return annotation claimed a tuple while a single expression was returned. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places independently split a SymPy polynomial into its monomial terms, and most did so incorrectly: they iterated
.args/make_argswithout expanding, so products of sums, single-term polynomials, and rawPolyobjects (whose.argsalso include the generators) were mishandled.This PR adds
abstract.iter_monomial_terms, which expands products of sums and returns the monomials of any Expr / Poly / integer uniformly, and route all call sites through it:GroupRing.eval,BBCode.get_canonical_form,get_syndrome_subgraphs, andget_equivalent_toric_layout_code_data.This GR also fixes bugs in
get_canonical_form: the coefficient was multiplied once per symbol (coeff**num_symbols, wrong for non-binary fields), aPolyargument leaked its generators as spurious terms, and the return annotation claimed a tuple while a single expression was returned.