Skip to content

FIX/#8#10

Merged
Zethson merged 3 commits intomasterfrom
feature/#8
Jul 2, 2019
Merged

FIX/#8#10
Zethson merged 3 commits intomasterfrom
feature/#8

Conversation

@Zethson
Copy link
Copy Markdown
Collaborator

@Zethson Zethson commented Jun 25, 2019

Should solve #8

@sven1103 could you very quickly glance over it, please?

I've disabled python 2, 3.4 and 3.5 support.
Python 2 is dead and should finally die. I hope that no one here still uses it.

Since I'm a fan of fstrings and IIRC those come with python 3.6 I would also drop support for 3.4 and 3.5.
Python 3.6 is the default on all Linux distributions now and I don't think that there's any reason to use 3.4 or 3.5 with 3.8 already on the horizon.

@Zethson Zethson requested a review from sven1103 June 25, 2019 13:24
@Zethson Zethson self-assigned this Jun 25, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2019

Codecov Report

Merging #10 into master will increase coverage by 1.69%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   80.48%   82.18%   +1.69%     
==========================================
  Files           4        4              
  Lines         246      247       +1     
==========================================
+ Hits          198      203       +5     
+ Misses         48       44       -4
Impacted Files Coverage Δ
rmageddon/lint.py 82.92% <92.85%> (+3.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac713e3...522dc2c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant