-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Change qbittorrent logo. Issue #6467. #6484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e88f18
to
91704ee
Compare
@LordNyriox Just so you know, I inspected the old icns and ico files to see what sizes they used. And then I used same sizes for the new icon. I have no problem using files created by you. |
Hi @LordNyriox, my design lacks vectors completely, so can't be exported to SVG... 😊 |
Please stop deleting your comments, it's annoying! I started with 2 layers (one for the text and another for the orb), then rendered both to be able to use image-oriented tools and effects (I couldn't do what I wanted with vectors). If you really need a SVG for the job you can embed a picture like this: <?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd">
<svg id="test" width="512px" height="512px" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<image x="0px" y="0px" width="512px" height="512px" xlink:href="whatever.png"></image>
</svg> |
IMO, better focus on the svg one. Sorry @bugmenot2. Thanks for the contribution though. |
Excuse me @sledgehammer999, 1024 x 1024 for an icon isn't enough? |
It is enough, but if @LordNyriox prefers to work with svg, I just told him to let go of trying to get an svg version of your logo. Generally we're trying to migrate to svg so we can load them natively in Qt without relying on generated pngs. Presumably this will help with scaling and highDPI screens. |
I'm fine working with @LordNyriox to get this job done, I also have the necessary knowledge/toolset to build icons and PNGs for the program 😄 |
@bugmenot2 Why in svg the link to png? |
Dear @bugmenot2 , thank you for the work you have done. PS. |
Nah, your question was fine, voting down my comment was a little rough though 😄 |
First, I do like @bugmenot2 icon. |
@bugmenot2 Alas, the last option is not vector. You were asked to provide a vector version of the logo, if possible. something like that (based on bugmenot2 qBittorrent-1024.png) - qBittorrent-vector(draft).zip (My skills in owning vector graphics are very small, the quality may be insufficient) |
Hi @LordNyriox, The png that you have exported have a lot of aliasing. Here is the anti-aliased version: Also the color is not correct for the mac version (.icns file) |
I'll recreate @bugmenot2's version of icon tomorrow in proper vector format in Sketch app. |
... |
Both logo with original source sketch file and exported resources(only .ico is not there): |
@LordNyriox, @atfzl, @sledgehammer999 that about qbit.zip 1024px change: add text shadow |
I like @atfzl new svg too. @surfernsk your mod looks good too but nowadays my preference tends to the "flat design" side. I could be wrong. I have to look at the smaller icons too. There they might look much better. Thx for the contributions guys, I'll try to look at them this weekend. |
@sledgehammer999 I was wondering if I still got the chance to make some logo design before this is approved. |
I had a sudden question/realization: I started wondering about the Verdana license. I didn't find a definitive answer. Maybe it is a good idea to switch to "open sans" font to be sure? |
@sledgehammer999 Logo with Open Sans (optimized, 1004px) download |
@sledgehammer999 What do you think about P.S. |
65cc3d7
to
e37f31f
Compare
@surfernsk I proceeded on my own because this back-n-forth action takes time. I removed the padding around the circle as mentioned earlier. Then I used the same ratio to increase the font size. I used Inkscape to re-center vertically+horizontally the bigger text. And then I converted the letters to paths. (I used the open sans font). I have pushed new commits using the new svg with open sans font. I think this is my final decision. I have included both svgs, one that uses the font and one that uses path for the letters. For easier modification down the road. Minor tweaks can be performed afterwards with new PRs. |
bf85198
to
1135a71
Compare
I think I'll find time this weekend to make macOS icns files too. Then this will be merged and v4.0.0 will be released. @bug-me-not did you see my reply on your PM? |
@bug-me-not One final PM in the forum by me. |
1135a71
to
0873483
Compare
0873483
to
a89c1a8
Compare
Merging this since I am beginning the release of v4.0.0. Thx to all contributors, commentators and critics. |
Hey guys, the new icon is not production ready on 4.0.0. It's aliased on every small size. Definitely needs work. |
See #7725 (comment) |
<file>icons/flags/zw.svg</file> | ||
<file>icons/L.gif</file> | ||
<file>icons/loading.png</file> | ||
<file>icons/qbittorrent.png</file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't wait until #7610. Just return it back. |
All pngs where created via GIMP. The .ico file was created by taking the relevant pngs and using
icotool
program. The .icns file was created by taking the relevant pngs and usingpng2icns
program.I wasn't able to find a program for the OS/2 .ico format (different from the Windows .ico) until I started commiting and compiling. But after that I found 2 promising programs Deark and Image Alchemy. I will try them later.
Caveats:
src/icons/skin/splash.png
has the old log embeddedsrc/qbittorrent_file.ico
wasn't recreated. I think I can do it if use the new logo plussrc/icons/qbt-theme/text-plain.png
from the old theme. Same goes fordist/mac/qBitTorrentDocument.icns
Pics:


Notice how crappy the icon looks as an window-icon and as tray-icon? I think this is actually a regression of qt with 5.7.0 (or 5.7.1 don't remember). Can you confirm that it looks crap on yours too?