Removed invalid await from grpc async call - #785
Merged
Conversation
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Hi @VanaMartin Thank you for your contribution However, we can't accept it right now, because async client is auto-generated from sync client and changes to async files can't be done without altering either sync client or generator code We'll investigate the issue |
Member
|
I have found and fixed the issue and extended tests coverage |
joein
approved these changes
Sep 24, 2024
coszio
approved these changes
Sep 24, 2024
joein
added a commit
that referenced
this pull request
Sep 24, 2024
* Removed invalid await from grpc async call * fix: fix generation of grpc async create shard key, add tests --------- Co-authored-by: George Panchuk <george.panchuk@qdrant.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?Changes to Core Features:
This PR only removes invalid
awaitclause from initialising grpc request. The existingawaitwas causing folowing exception (on version 1.11.2):I've tested the local behaviour with a positive result.