[Server] Add server properties on layer tree group#61195
[Server] Add server properties on layer tree group#61195troopa81 merged 5 commits intoqgis:masterfrom
Conversation
As a consequence, it's now possible to edit all server properties for group (metadata urls, keyword list, attribution...)
Use map layer server properties method instead
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Core changes look good to me. The new action does make me think we should consider adding a global option for "Expose QGIS Server configuration options" , which, if not checked (the default being unchecked), would hide all these types of actions throughout the app UI. The group context menu is very frequently used, and for the majority of users they'll never need this QGIS server specific option. |
|
Nice, this is going to be useful for generating STAC infomations from QGIS server capabilities data. |
|
Re-run CI, there is another (non related) failure
Can we merge then ?
I don't like much UI pieces hidden by default. User can spend lot of time searching for them. And I think this is a more global issue to QGIS where user uses only a tiny bit of button/menus/panel and would like to be able to configure their visibility. |
|
I would also be in favor of a global toggle for server options. I think server is a quite well isolated (in terms of coherence) topic so it would be quite natural that you need to enable it. The other approach I would consider would be to have a dedicated layer tree for server config (like we do for snapping) where you could define this and would be hosted in the project properties or in its own dialog. |
I have always thought that the server config in its current state is polluting the GUI for the benefit of a extremely tiny fraction of the users which is not ideal. So hiding it behind a global toggle (disabled by default) seems a good idea to me. |
The menu item is already existing, this PR propose only to add the same field widgets that already exist for vector layer, raster layer and vector tile layer. I don't mind discussing whether or not we should alleviating the GUI from server options but it's beyond the scope of this PR. |
|
Hello! I tend towards leaving QGIS Server GUI options visible by default as users can indeed spend a lot of time searching for them if they aren't enabled by default. I've been seeing a lot of users get confused by the disappearance of Processing/Topology and Geometry checker core plugins and they really have a hard time toggling them on back by themselves. Users do spend a lot of time searching for them if they aren't available in a moment. A toggle option with default ON would be nice though. |
|
Ok, I'm going to file a QEP to add this switch (default to on for one release, default to off for 4.0) 😜 No objections to merging this as is |
|
Couldn't we leave the options page on the project properties visible by default and have an option in there to enable the current project for server and make that a project property rather than a global QGIS option? |
|
I fully support a new option to enable/disable QGIS Server for each project. To support this, we need a new first tab in QGSI Server options with a checkbox. But we can move some other existing options to this first new tab, like the one to "Test Configuration". Other QGIS Server options that we can set or unset using environment variables can be added here also, like "Ignore invalid layers"- But this is another QEP/PR just to redesign the QGIS Server options. It does not make sense to have all this logic in this PR. I can contribute to this new QEP/PR to redesign the QGIS Server options and review all the UI where QGIS Server related options can be hidden. |
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
|
@troopa81 A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
|
@troopa81 |
Allow user to edit server properties on layer tree group and return them on GetCapabilities request. So far, only short name, title and abstract were available. There are now:
Widget
GetCapabilities response
Funded by Ifremer