1084 data changes #1204
1084 data changes #1204
Conversation
…it was unsafe becasue it was using purge_filepaths
…y of the raw data, and fix the status property and its tests
qiita_db/data.py
Outdated
There was a problem hiding this comment.
Just checking, is it really an IncompetentQiitaDeveloperError or a QiitaError? I'm thinking than a user can hit this error from IPython.
|
1 minor comment so 👍 |
qiita_db/data.py
Outdated
There was a problem hiding this comment.
Was this method not used anywhere else? That's surprising 👀
There was a problem hiding this comment.
Yup, it was not used, sorry I forgot to comment that on the PR. I checked and it was not used. This function was intended to remove a single filepath from the raw data, but we are not supporting right now because it gets tricky: we are checking if the raw data has the same number of barcode files and forward reads, so removing a single file will break this checks. Thus, we are allowing just removing all using clear_filepaths
Also, this function was using purge_filepaths instead of move_filepaths_to_upload_folder.
Given that it was not used, and I don't see a use for it soon; and it's a developer burden to maintain it, I think is better to remove it and we will re-add it if we actually need it.
|
Very minor comments, should be good to go after. |
|
Comments should be addressed @antgonza @ElDeveloper |
|
Got it, thanks! 👍 ready for merge. On (May-27-15|16:03), josenavas wrote:
|
3 participants
Built on top of #1203 (review/merge that one first)This PR modifies the RawData object to reflect the changes in the DB. It also fixes the tests for the RawData object.
All the other tests are still expected to fail.