Skip to content

Conversation

@josenavas
Copy link
Contributor

Built on top of #1204

Makes qiita_db to pass al tests. Still failures expected on qiita-ware and qiita-pet.

@josenavas josenavas added this to the Alpha 0.2 milestone May 24, 2015
@josenavas josenavas mentioned this pull request May 24, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can bring this line up, no?

@antgonza
Copy link
Member

1 minor comment 👍

@josenavas
Copy link
Contributor Author

Done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There used to be four raw datas associated to this study but now there's only one? How would that happen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed them in populate_test_db.sql. Keeping them would require adding 3 more prep templates there, which is a lot of work...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ElDeveloper
Copy link
Contributor

1 question, but 👍 (for the most part 💯 ).

ElDeveloper added a commit that referenced this pull request May 28, 2015
@ElDeveloper ElDeveloper merged commit 250ae69 into qiita-spots:fix-1084 May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants