1084 qiita ware #1206
Merged
1084 qiita ware #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
There was a problem hiding this comment.
A really minor thing would be to make this path_builder an attribute of the test so it can also be used in line 388.
Contributor
|
👍 just 1 minor suggestion that should not be considered blocking. |
Contributor
Author
There was a problem hiding this comment.
filepath_type_id of raw_sff. Added a comment explaining what it is
Contributor
Author
There was a problem hiding this comment.
I'm changing this to use convert_to_id, better than the magic number...
Member
|
Minor comments about magic numbers clarifications ... |
Contributor
Author
|
@antgonza @ElDeveloper comments should be addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1205
Fixes all tests for qiita-ware. Failures still expected on qiita-pet.