adding recover jobs script #2135
Merged
+137
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2135 +/- ##
==========================================
+ Coverage 92.04% 92.05% +<.01%
==========================================
Files 191 191
Lines 19515 19515
==========================================
+ Hits 17963 17964 +1
+ Misses 1552 1551 -1
Continue to review full report at Codecov.
|
josenavas
approved these changes
Aug 8, 2017
ElDeveloper
approved these changes
Aug 8, 2017
Contributor
ElDeveloper
left a comment
ElDeveloper
left a comment
There was a problem hiding this comment.
Just a few minor comments, also can you check that scripts/qiita-recover-jobs is executable?
scripts/qiita-recover-jobs
Outdated
| qiita_jids = [] | ||
| for qj in qiita_jobs: | ||
| # to retrieve info about the jobs we need to use the fullname, so | ||
| # prepending .ucsd.edu |
Contributor
There was a problem hiding this comment.
prepending -> appending
scripts/qiita-recover-jobs
Outdated
| status = set([ProcessingJob(v).status | ||
| for v in validators if v not in qiita_jids]) | ||
| # if there are no status, that means that the validators weren't | ||
| # created and we shour rerun from scratch (Step 4) |
scripts/qiita-recover-jobs
Outdated
|
|
||
| jids_to_recover = jids_to_recover - set(jobs_with_validators) | ||
|
|
||
| # Step 4: Finally, we recover all the left over jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during the qiita meeting this is an internal script to recover jobs once the system fails. @wasade and @josenavas, could you take a look?