Skip to content

Improve project #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2015
Merged

Improve project #101

merged 4 commits into from
Dec 3, 2015

Conversation

@codedogfish
Copy link
Contributor

@codedogfish codedogfish commented Dec 2, 2015

这个 PR 将逐步改善项目结构：

  1. 通过 bower 管理对三方库的依赖和版本
  2. 输出 qiniu.js 和 qiniu.min.js 加上头信息
  3. 升级 plupload

@longbai
Copy link
Contributor

longbai commented Dec 2, 2015

👍

@SunLn
Copy link
Contributor

SunLn commented Dec 2, 2015

赞

@tonybearpan
Copy link

tonybearpan commented Dec 2, 2015

Cool

在 2015年12月2日，上午10:44，SunLn notifications@github.com 写道：

赞

—
Reply to this email directly or view it on GitHub #101 (comment).

@longbai
Copy link
Contributor

longbai commented Dec 2, 2015

另外 最好 在.travis 加上 jshint 检查

@sorcerer-ma
Copy link

sorcerer-ma commented Dec 2, 2015

bower.json 里加上 main 属性吧

@codedogfish
Copy link
Contributor Author

codedogfish commented Dec 2, 2015

@SunLn @sorcerer-ma @longbai

目前完成的情况，重写了 Gruntfile.js 和改了 demo 相关的东西

  • 给 qiniu.min.js 增加了 sourcemap
  • 所有文件输出到 dist 目录下
  • js 增加了头信息
  • demo 里需要的三方库改成 bower_components (bower.json 的 main 属性 dist/qiniu.js)

各位有空的话帮忙 review 一下，没问题就合并到 develop 分支上了

后续还要推进如下工作：

  • 将近期帮用户临时解决的几个 issue 逐个更新到 repo 中
  • 增加测试

@codedogfish codedogfish changed the title Add bower and change package info Improve project Dec 2, 2015
@codedogfish
Refact demo folder
b89cfaa
@codedogfish
Rewrite Gruntfile.js
ec6ea25 
1. Add header comment
1. Create sourcemap for qiniu.min.js
2. Output file to dist
3. Add travis check
codedogfish added a commit that referenced this pull request Dec 3, 2015
@codedogfish
Merge pull request #101 from codedogfish/improve_project
4ee91a9 
Improve project
@codedogfish codedogfish merged commit 4ee91a9 into qiniu:develop Dec 3, 2015
This was referenced Dec 3, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codedogfish @longbai @SunLn @tonybearpan @sorcerer-ma