Remove bounds from T1 #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ready for review |
blakejohnson
approved these changes
Jul 21, 2021
Contributor
blakejohnson
left a comment
blakejohnson
left a comment
There was a problem hiding this comment.
LGTM. A further enhancement would add a "quality" check that compared the fitted amplitude to the amplitude of the noise. This essentially amounts to demanding some minimum SNR.
coruscating
added a commit
that referenced
this pull request
Jul 22, 2021
* ResultsDB tutorial (#208) * added warning and test * added tutorial * formatting * added load data * changed to experimentdata * updated loade data * changed load syntax * Calibrations tutorial (#184) * * Added calibrations tutorial. * Added time-zone fix in Calibrations. * * Propagating timezone change. * * Docs for NB. * * NB rewording. * * Test math. * * Math in DRAG. * Update docs/tutorials/rb_example.ipynb * Update docs/tutorials/qst_example.ipynb * Update docs/tutorials/qst_example.ipynb * Update docs/tutorials/qst_example.ipynb * Update docs/tutorials/qv_example.ipynb * * Added comment on parameters and channels. * Update docs/tutorials/calibrating_armonk.ipynb Co-authored-by: Will Shanks <wshaos@posteo.net> * Update docs/tutorials/calibrating_armonk.ipynb Co-authored-by: Will Shanks <wshaos@posteo.net> * * Added comment on Amplitude.update. * * DRAG text. * * Added comment on qubit frequencies. * * Added change and comment to show the initial guess values. * * Updated Armonk NB with xm schedule and unlinked amp and beta for xp and x90p. Co-authored-by: Will Shanks <wshaos@posteo.net> Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> * Fix errors in QST notebook (#214) * Make `block_for_results` return self * Fix errors in qst notebook so it runs Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> * Automatic documentation for experiment and analysis (#116) * initial commit model based experiment * Revert "initial commit model based experiment" This reverts commit eb60945. * wip options field * fix bug * update type handling * black * add experiment options update and class docstring update * cleanup facades and make autodoc module a package * wip analysis documentation * update analysis docs and reformat styles. * black and typing * wip lint * replace LF * strip LFs of input text * update irb docstring * ignore lint * unittest * Update qiskit_experiments/analysis/curve_analysis.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Update qiskit_experiments/characterization/qubit_spectroscopy.py Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> * Sphinx autodoc extension for documentation * revert experiment modules * remove old autodoc module * fix old import * remove change to base analysis * update docs * lint * add example of analysis default options * move package under docs * fix import path * fix missing docs * comment from Eli - add template for example - section indent and rf rule update * fix indent correction logic * update example * robust to indent error - add extra indent check - autofix section indent error * fix import paths * fix example documentation Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> * Remove bounds from T1 (#168) * Remove bounds from T1 * reverting the tutorial Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> * Set minimum python version to 3.7 (#227) This commit changes the minimum supported python version from 3.6 to 3.7. qiskit-experiments uses dataclasses internally which was a python feature introduced in 3.7 and the code as packaged doesn't actually work on 3.6. This hasn't been caught in CI because a test dependency of qiskit-experiments is installing the dataclasses backport package as a dependency which is masking this issue. While we can list that package as a depedency of qiskit-experiments too to resolve this, python 3.6 is deprecated in the upstream qiskit packages and the next qiskit-terra minor version release (0.19.0) will be the last to support it. At this point it just makes more sense to drop 3.6 support. At the same time the minimum supported version of the qiskit-terra package is bumped to the latest release 0.18.0 which is actually the minimum version needed (we were installing from git in CI to workaround this pre-0.18.0 release) and 0.17.0 was the release which deprecated python 3.6 in qiskit which lines up well with dropping 3.6 support here. * Fix headers in RB tutorial (#223) Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com> Co-authored-by: Will Shanks <wshaos@posteo.net> Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com> Co-authored-by: Naoki Kanazawa <knzwnao@jp.ibm.com> Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
paco-ri
pushed a commit
to paco-ri/qiskit-experiments
that referenced
this pull request
Jul 11, 2022
* Remove bounds from T1 * reverting the tutorial Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #161, this PR removes bounds from T1 experiments. The same should probably be done for all the experiments.
Details and comments
This PR includes a bug fix in
curve_fitting.py, which is relevant to all the experiments, as long bounds exist. The bug occurs when theboundsparameter ofcurve_fitisNone.