Skip to content

Conversation

@coruscating
Copy link
Collaborator

@coruscating coruscating commented Jul 21, 2021

Summary

ResultsDB tutorial (T1 and RB) and small graphics fix in utils.py so that figures render correctly in the database without being cut off.

What's not in here/not done:

  • Composite experiments: we haven't decided how to implement that in ResultsDB
  • Deleting figures and/or analysis results: I tested several times and it doesn't work consistently. Deleting figures in particular doesn't seem to work at all. It's also not such an important feature that I think it's fine to leave off the tutorial for now
  • T2* not in here for now because there's no figure, also doesn't really need to be in here since T1 is similar
  • Tomography not in here for now because Armonk doesn't support reset
  • Screenshot of ResultsDB doesn't show chi square, pending resolution of Fetch value, chisq, result_type from the result data #194

@coruscating coruscating added this to the Release 0.1 milestone Jul 21, 2021
@yaelbh
Copy link
Collaborator

yaelbh commented Jul 21, 2021

@mtreinish What's the policy about using devices in tutorials?

@yaelbh
Copy link
Collaborator

yaelbh commented Jul 21, 2021

In your screenshot for T1, the column "Verified" is not populated. This is how it should be, but it's not the way it is right now. It's fixed in the non-merged PR #200. So I wonder how it happened.

@coruscating
Copy link
Collaborator Author

@yaelbh I fixed it temporarily just for the screenshot :p But it's not so useful since I'll have to redo the screenshot later for the chisq...

@blakejohnson
Copy link
Contributor

blakejohnson commented Jul 21, 2021

To be clear #194 on its own won't fix chisq. It also needs to be pulled "up" a level in the dictionary. Sorry, I thought that was referencing a different issue.

@mtreinish
Copy link
Contributor

@yaelbh normally using devices in tutorials is not allowed because we can't execute the tutorials in CI for PRs if they need credentials (and there is the runtime concern too if they run on a shared device). The other qiskit repos execute their tutorials in CI for PRs to validate against regressions from the PR and also before publishing the docs so the rendered pages (like https://qiskit.org/documentation/tutorials/noise/4_randomized_benchmarking.html ) are running in a consistent environment with the same versions. But so far the experiments project doesn't actually execute the tutorials in CI anywhere if you want to continue this trend then using devices is fine, but the tradeoff is that then we can't actually run tests on PRs to validate tutorials still work with code changes (and also the hosted documentation will have whatever output is set for cells in the committed version of the notebook).

@coruscating coruscating merged commit 821c023 into qiskit-community:main Jul 22, 2021
coruscating added a commit that referenced this pull request Jul 22, 2021
* added warning and test

* added tutorial

* formatting

* added load data

* changed to experimentdata

* updated loade data

* changed load syntax
coruscating added a commit that referenced this pull request Jul 22, 2021
* ResultsDB tutorial (#208)

* added warning and test

* added tutorial

* formatting

* added load data

* changed to experimentdata

* updated loade data

* changed load syntax

* Calibrations tutorial (#184)

* * Added calibrations tutorial.
* Added time-zone fix in Calibrations.

* * Propagating timezone change.

* * Docs for NB.

* * NB rewording.

* * Test math.

* * Math in DRAG.

* Update docs/tutorials/rb_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qv_example.ipynb

* * Added comment on parameters and channels.

* Update docs/tutorials/calibrating_armonk.ipynb

Co-authored-by: Will Shanks <wshaos@posteo.net>

* Update docs/tutorials/calibrating_armonk.ipynb

Co-authored-by: Will Shanks <wshaos@posteo.net>

* * Added comment on Amplitude.update.

* * DRAG text.

* * Added comment on qubit frequencies.

* * Added change and comment to show the initial guess values.

* * Updated Armonk NB with xm schedule and unlinked amp and beta for xp and x90p.

Co-authored-by: Will Shanks <wshaos@posteo.net>
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Co-authored-by: Will Shanks <wshaos@posteo.net>
coruscating added a commit that referenced this pull request Jul 22, 2021
* ResultsDB tutorial (#208)

* added warning and test

* added tutorial

* formatting

* added load data

* changed to experimentdata

* updated loade data

* changed load syntax

* Calibrations tutorial (#184)

* * Added calibrations tutorial.
* Added time-zone fix in Calibrations.

* * Propagating timezone change.

* * Docs for NB.

* * NB rewording.

* * Test math.

* * Math in DRAG.

* Update docs/tutorials/rb_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qst_example.ipynb

* Update docs/tutorials/qv_example.ipynb

* * Added comment on parameters and channels.

* Update docs/tutorials/calibrating_armonk.ipynb

Co-authored-by: Will Shanks <wshaos@posteo.net>

* Update docs/tutorials/calibrating_armonk.ipynb

Co-authored-by: Will Shanks <wshaos@posteo.net>

* * Added comment on Amplitude.update.

* * DRAG text.

* * Added comment on qubit frequencies.

* * Added change and comment to show the initial guess values.

* * Updated Armonk NB with xm schedule and unlinked amp and beta for xp and x90p.

Co-authored-by: Will Shanks <wshaos@posteo.net>
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

* Fix errors in QST notebook (#214)

* Make `block_for_results` return self

* Fix errors in qst notebook so it runs

Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

* Automatic documentation for experiment and analysis (#116)

* initial commit model based experiment

* Revert "initial commit model based experiment"

This reverts commit eb60945.

* wip options field

* fix bug

* update type handling

* black

* add experiment options update and class docstring update

* cleanup facades and make autodoc module a package

* wip analysis documentation

* update analysis docs and reformat styles.

* black and typing

* wip lint

* replace LF

* strip LFs of input text

* update irb docstring

* ignore lint

* unittest

* Update qiskit_experiments/analysis/curve_analysis.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Update qiskit_experiments/characterization/qubit_spectroscopy.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

* Sphinx autodoc extension for documentation

* revert experiment modules

* remove old autodoc module

* fix old import

* remove change to base analysis

* update docs

* lint

* add example of analysis default options

* move package under docs

* fix import path

* fix missing docs

* comment from Eli
- add template for example
- section indent and rf rule update

* fix indent correction logic

* update example

* robust to indent error
- add extra indent check
- autofix section indent error

* fix import paths

* fix example documentation

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

* Remove bounds from T1 (#168)

* Remove bounds from T1

* reverting the tutorial

Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

* Set minimum python version to 3.7 (#227)

This commit changes the minimum supported python version from 3.6 to
3.7. qiskit-experiments uses dataclasses internally which was a
python feature introduced in 3.7 and the code as packaged doesn't
actually work on 3.6. This hasn't been caught in CI because a test
dependency of qiskit-experiments is installing the dataclasses backport
package as a dependency which is masking this issue. While we can list
that package as a depedency of qiskit-experiments too to resolve this,
python 3.6 is deprecated in the upstream qiskit packages and the next
qiskit-terra minor version release (0.19.0) will be the last to support
it. At this point it just makes more sense to drop 3.6 support.

At the same time the minimum supported version of the qiskit-terra
package is bumped to the latest release 0.18.0 which is actually the
minimum version needed (we were installing from git in CI to workaround
this pre-0.18.0 release) and 0.17.0 was the release which deprecated
python 3.6 in qiskit which lines up well with dropping 3.6 support here.

* Fix headers in RB tutorial (#223)

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Co-authored-by: Will Shanks <wshaos@posteo.net>
Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
Co-authored-by: Naoki Kanazawa <knzwnao@jp.ibm.com>
Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
paco-ri pushed a commit to paco-ri/qiskit-experiments that referenced this pull request Jul 11, 2022
* added warning and test

* added tutorial

* formatting

* added load data

* changed to experimentdata

* updated loade data

* changed load syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants