Skip to content

Conversation

@qmacro
Copy link
Owner

@qmacro qmacro commented Nov 10, 2018

this is the second slide

this is the second slide
Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 7: Respond to a review

Your pull request is looking great!

Let’s add some content to your file. Replace line 5 of your file with a quotation or meme and witty caption. Remember: Markdown is supported.

⌨️ Activity: Change your file

  1. Click the "Files Changed" tab in this pull request
  2. Click on the pencil icon found on the right side of the screen
  3. Replace line 5 with something new
  4. Scroll to the bottom and click Commit Changes

Watch below for my response

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 8: Merge your pull request

Nicely done @qmacro! ✨

You successfully created a pull request, and it has passed all of the tests. You can now merge your pull request.

⌨️ Activity: Merge the pull request

  1. Click Merge pull request
  2. Click Confirm merge
  3. Once your branch has been merged, you don't need it anymore. Click Delete branch.

Watch below for my response

@qmacro qmacro merged commit 0b369f1 into master Nov 10, 2018
@github-learning-lab
Copy link

Nice work

celebrate

Congratulations @qmacro, you've completed this course!

What went well

Now, you have your slide deck deployed here and you've gone through the GitHub Flow.

Before I say good-bye, here's a recap of all the tasks you've accomplished in your repository:

  • You learned about issues, pull requests, and the structure of a GitHub repository
  • You learned about branching
  • You created a commit
  • You viewed and responded to pull request reviews
  • You edited an existing file
  • You enabled GitHub Pages
  • You made your first contribution! 🎉

What's next?

We hope this course helped you feel more comfortable using GitHub. Remember: You’re always welcome to repeat course topics if you’d like additional practice. If you’re ready to build on your new skills, here are some ideas.

Contribute to a project

To find projects to contribute to through trending topics and curated collections, check out GitHub Explore.

Keep learning

Check out the other GitHub Learning Lab courses in your Dashboard! What will you learn next?

@qmacro qmacro deleted the my-first-new-branch branch November 10, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants