build(deps-dev): bump @biomejs/biome from 2.4.16 to 2.5.4 - #252
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker | Jun 29, 2026 11:50p.m. | Review ↗ | |
| JavaScript | Jun 29, 2026 11:50p.m. | Review ↗ | |
| CSS | Jun 29, 2026 11:50p.m. | Review ↗ | |
| Rust | Jun 29, 2026 11:50p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
f98fbb2 to
a8815d0
Compare
|
Pushed a fix for the immediate CI failure: `biome.json`'s `$schema` still pointed at 2.4.16 while the bumped CLI is 2.5.4 — biome's own parser flags that mismatch as a warning, escalated to a hard failure by `--error-on-warnings`. That fix alone isn't enough to merge, though. Biome 2.5.x enables/tightens two rules this repo doesn't yet satisfy:
Both need real fixes (or, for the env-var rule, a deliberate config decision), not a suppression — leaving this open rather than merging with new lint debt or a fresh `biome-ignore`. Full list reproducible locally with `pnpm exec biome lint --max-diagnostics=200` after this branch's schema fix. |
|
Pushed the remaining fixes — this should now be fully mergeable:
Verified locally: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeAnt-AI review |
Bumps [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) from 2.4.16 to 2.5.4. - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.4/packages/@biomejs/biome) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot's version bump didn't update the config schema reference, which biome's own parser flags as a warning -- escalated to a hard lint failure by --error-on-warnings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…essions) Biome 2.5.4 (bumped from 2.4.16 by Dependabot) enables two rules the codebase didn't yet satisfy: - lint/correctness/noUnsafeOptionalChaining (4 errors): each was the pattern `(x?.[n] as T).prop` / `(x?.[n] as (...) => T)()` -- optional chaining protects the property access but not the subsequent cast + call/access, which throws at runtime if the chain short-circuits. Fixed by extracting the optional-chain result into its own variable first (a separate statement), which is both safe and satisfies the rule, in tests/unit/collaborationService.test.ts, tests/unit/hooks/useManuscriptView.test.ts (x2), and tests/unit/ragVectorMigration.test.ts. - lint/suspicious/noUndeclaredEnvVars (16 warnings, escalated to failures by --error-on-warnings): env vars used across scripts, config files, and tests weren't declared in turbo.json's globalEnv, so Turborepo's cache correctness couldn't account for them. Declared all 16 (ANALYZE, BASE_URL, CF_PAGES*, CLOUDFLARE_*, DEPLOY_TARGET, DEV, GRAPHIFY_SKIP, PLAYWRIGHT_*, RUN_*_E2E, SMOKE_PORT). Also ran `biome migrate` for the linter.rules.recommended -> linter.rules.preset config rename (deprecation notice, not error-level, but biome's own suggested fix and trivial). Verified: pnpm run lint (clean), pnpm run typecheck (clean), pnpm run suppressions:check (52/52, no new suppressions), and the 3 affected test files (81 tests passing). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
739bc53 to
297a104
Compare
Bumps @biomejs/biome from 2.4.16 to 2.5.4.
Release notes
Sourced from @biomejs/biome's releases.
... (truncated)
Changelog
Sourced from @biomejs/biome's changelog.
... (truncated)
Commits
bfc3f3dci: release (#10887)9e1999fchore: revert the revert0b0fd8dchore: revert0afa35aci: release (#10817)3447b2ffeat(useDomQuerySelector): add ignore option (#10835)e649198ci: release (#10747)4a32b63feat(lint): add ignorePrimitives option to useNullishCoalescing (#10798)f3d4c00feat(js/nursery): add noSvelteNoUnnecessaryStateWrap rule (#10545)f458028feat(lint): add ignoreBooleanCoercion option to useNullishCoalescing (#10595)ffe7d33chore: revert