[CLEAN] Synthetic Benchmark PR #25664 - Fixed free welcome emails being sent to new paid members#141
Open
ofir-frd wants to merge 2 commits intobase_pr_25664_20260120_6155from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR TryGhost#25664
Type: Clean (correct implementation)
Original PR Title: Fixed free welcome emails being sent to new paid members
Original PR Description: closes https://linear.app/ghost/issue/NY-857/free-member-welcome-email-is-sent-to-new-paid-members
Currently if free welcome emails are enabled, and a new member signs up for a paid subscription, they will receive the free welcome email in error. This is because new paid members are initially created in the
freestatus, until the Stripe subscription is fully processed, at which point they transition topaid.This fixes the bug by opting to skip sending the welcome email if the member has a
stripeCustomerattached, which indicates that the member at least intends to become a paid member.Original PR URL: TryGhost#25664