fix(presets): align list editor row delete button with row content#1093
Closed
Transmigration-zhou wants to merge 1 commit into
Closed
fix(presets): align list editor row delete button with row content#1093Transmigration-zhou wants to merge 1 commit into
Transmigration-zhou wants to merge 1 commit into
Conversation
The delete button was floated at the card's top-right regardless of the row height, so on rows with multiple stacked fields it visually detached from the row (e.g. sat next to the first field only). Lay each row out with flex and center the button against the row content instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195isT8XZBhZ3wwcWTYKtgV
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Jul 6, 2026 6:47a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
molon
approved these changes
Jul 6, 2026
Contributor
Author
|
Superseded by #1094 (same commit, resubmitted from an in-repo branch so CI can assume the AWS OIDC role). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The list editor's per-row delete button is rendered with
float-right ma-2, which pins it to the card's top-right corner regardless of the row height:pt-4 pb-0).Reported downstream in kakuyasu seller portal (KGM-4586), but it affects every
Nestedslice field rendered byListEditorBuilder.Fix
Lay each row card out with flex instead of float: the content wraps in a
flex-grow-1div and the delete button follows it withalign-self-center, so it stays vertically centered against the row content at any row height. Vuetify utility classes only; the click binding is unchanged.Testing
go test ./presets/...passes (including integration).go.modreplace: on a two-field (Start/End) row the button now centers between the fields, on a single-field row it aligns with the input, and row deletion still works.🤖 Generated with Claude Code