Filter Event Handler Expression - #197
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for an expression filter on FilterEventHandler so handlers can accept/reject events based on a parsed core expression, and introduces a comprehensive unit test suite for FilterEventHandler filtering and dispatch behavior.
Changes:
- Parse optional
filter["expression"]into acore_expressions.Expressionduring filter preparation. - Evaluate the filter expression inside
accepts()to gate event acceptance. - Add unit tests covering attribute/value/type filtering, expression filtering, lazy filter preparation, dispatch behavior, and state getters.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
qtoggleserver/lib/filtereventhandler.py |
Adds parsing/storage of a filter expression and evaluates it during accepts() to decide whether to handle an event. |
tests/unit/qtoggleserver/lib/test_filtereventhandler.py |
New unit tests validating filter matching behavior (attrs, transitions, port values, event types, expressions) and handler dispatch/state updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.