Skip to content

FROMLIST: usb: dwc3: qcom: Add support to skip phy management by USB … - #1625

Open
Kriskura176767 wants to merge 1 commit into
qualcomm-linux:tech/bus/usb/dwcfrom
Kriskura176767:for-dwc3
Open

FROMLIST: usb: dwc3: qcom: Add support to skip phy management by USB …#1625
Kriskura176767 wants to merge 1 commit into
qualcomm-linux:tech/bus/usb/dwcfrom
Kriskura176767:for-dwc3

Conversation

@Kriskura176767

@Kriskura176767 Kriskura176767 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Skip phy management by dwc3 core

@Kriskura176767
FROMLIST: usb: dwc3: qcom: Add support to skip phy management by USB …
a100955 
…core

DWC3 driver does manage phys itself sufficiently for Qualcomm platforms.
If xhci-skip-phy-init is not set, the HCD core does a phy_init and phy_
exit is done only when roothub is being destroyed. Due to this, during
system suspend in host mode, although phy_exit is done by DWC3 core, the
init_count on phy is never down to zero since HCD core also did an init.
consequently causing phy's exit routine to not be called. Hence, add
support to skip phy management by USB core.

Some Exynos platforms still do rely on USB core for phy_calibrate calls,
hence disable USB core management for Qualcomm platforms only.

Link: https://lore.kernel.org/all/20260723-dwc3-skip-init-quirk-v1-1-97682bb44ebd@oss.qualcomm.com/
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, Pratham Pratap (ppratap-liveroot) and wcheng-eng and removed request for a team August 3, 2026 00:30
@qlijarvis

qlijarvis commented Aug 3, 2026

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1625

PR: #1625
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30774620882

# Error File:Line PR-introduced? Root Cause
1 Merge conflict drivers/usb/dwc3/dwc3-qcom.c N/A PR changes conflict with existing topic branch topic/tech/bus/usb/dwc

Verdict

The build failed during the merge phase before compilation could begin. The PR introduces changes to drivers/usb/dwc3/dwc3-qcom.c that conflict with modifications already present in the integration branch. This is not a compilation error but a merge conflict that must be resolved by rebasing the PR on the current integration baseline.

📎 Detailed analysis: Full report

@qlijarvis

qlijarvis commented Aug 3, 2026

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1625

PR: #1625
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30774620882

# Error File:Line PR-introduced? Root Cause
1 Merge conflict drivers/usb/dwc3/dwc3-qcom.c Yes PR conflicts with existing changes in topic branch topic/tech/bus/usb/dwc that was merged before the PR

Verdict

This is not a compilation error but a merge conflict. The PR introduces changes to drivers/usb/dwc3/dwc3-qcom.c that conflict with changes already present in the topic branch topic/tech/bus/usb/dwc. The PR needs to be rebased on top of the current integration branch that includes the topic branch.

📎 Detailed analysis: Full report

@qlijarvis

qlijarvis commented Aug 3, 2026

Copy link
Copy Markdown

PR #1625 — validate-patch

PR: #1625

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: Yes — Link: https://lore.kernel.org/all/20260723-dwc3-skip-init-quirk-v1-1-97682bb44ebd@oss.qualcomm.com/ correctly added to commit message
  2. Lore link matches PR commits: Yes — diff fingerprint identical (e757baae210854c5e47c19445825c1e0); line number differences are context-only deltas due to different tree base
  3. Upstream patch status: ⏳ In review — posted July 23, 2026 (11 days ago); no maintainer decision yet (no ACK/NAK/applied signals in thread)
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1625 - FROMLIST: usb: dwc3: qcom: Add support to skip phy management by USB core
Upstream commit: https://lore.kernel.org/all/20260723-dwc3-skip-init-quirk-v1-1-97682bb44ebd@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream ✅ FROMLIST: prefix correctly added; base subject identical
Body preserves rationale ✅ Commit message body identical to lore patch
Fixes tag present/correct N/A No Fixes tag in upstream patch; not applicable
Authorship preserved ✅ Author matches lore: Krishna Kurapati krishna.kurapati@oss.qualcomm.com
Backport note (if applicable) N/A FROMLIST patch, not a backport

Diff

File Status Notes
drivers/usb/dwc3/dwc3-qcom.c ✅ Diff content identical; line numbers differ due to tree context (expected)

Verdict

Merge as-is. The patch faithfully represents the upstream lore posting with correct FROMLIST: prefix and proper Link tag.

Final Summary

  1. Lore link present: Yes — Link: https://lore.kernel.org/all/20260723-dwc3-skip-init-quirk-v1-1-97682bb44ebd@oss.qualcomm.com/ correctly added to commit message
  2. Lore link matches PR commits: Yes — diff fingerprint identical (e757baae210854c5e47c19445825c1e0); line number differences are context-only deltas due to different tree base
  3. Upstream patch status: ⏳ In review — posted July 23, 2026 (11 days ago); no maintainer decision yet (no ACK/NAK/applied signals in thread)
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial" status (subject or partial tree evidence found, but full change not verified in qcom-next)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: usb: dwc3: qcom: Add support to skip phy management partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

qlijarvis commented Aug 3, 2026

Copy link
Copy Markdown

PR #1625 — checker-log-analyzer

PR: #1625
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30774621250

Checker Result Summary
Checker Result Summary
checkpatch ❌ Merge conflict - unable to run
dt-binding-check ❌ Merge conflict - unable to run
dtb-check ❌ Merge conflict - unable to run
sparse-check ❌ Merge conflict - unable to run
check-uapi-headers ❌ Merge conflict - unable to run
check-patch-compliance ❌ Merge conflict - unable to run
tag-check ✅ Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1625 - FROMLIST: usb: dwc3: qcom: Add support to skip phy management by USB core
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30774621250
Target branch: tech/bus/usb/dwc

Checker Result Summary
checkpatch ❌ Merge conflict - unable to run
dt-binding-check ❌ Merge conflict - unable to run
dtb-check ❌ Merge conflict - unable to run
sparse-check ❌ Merge conflict - unable to run
check-uapi-headers ❌ Merge conflict - unable to run
check-patch-compliance ❌ Merge conflict - unable to run
tag-check ✅ Subject has valid FROMLIST: prefix

❌ All Checkers — Merge Conflict

Root cause: The PR cannot be merged cleanly into the integration branch due to a content conflict in drivers/usb/dwc3/dwc3-qcom.c.

Failure details:

Auto-merging drivers/usb/dwc3/dwc3-qcom.c
CONFLICT (content): Merge conflict in drivers/usb/dwc3/dwc3-qcom.c
Automatic merge failed; fix conflicts and then commit the result.
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

All six checker jobs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) failed at the merge stage before any checker logic could execute.

Analysis:

The PR modifies drivers/usb/dwc3/dwc3-qcom.c to add:

  1. A new include: #include <linux/property.h>
  2. A new function: dwc3_qcom_set_swnode() that sets the xhci-skip-phy-init-quirk property
  3. A call to dwc3_qcom_set_swnode() in the dwc3_qcom_probe() function

The conflict indicates that the integration branch (qcom-next + topic branches including tech/bus/usb/dwc) has diverged from the base where this patch was originally written. The conflict is in the same file being modified by the PR.

Possible causes:

  • Another commit in the integration branch modified overlapping lines in dwc3_qcom_probe() or nearby functions
  • The include section or function ordering changed in the integration branch
  • A related change to the same driver was merged that touches the same code regions

Fix:

The PR author needs to rebase the patch on top of the current tech/bus/usb/dwc branch (or the integration branch if targeting qcom-next):

# Fetch the latest topic branch
git fetch origin tech/bus/usb/dwc

# Rebase the PR branch
git rebase origin/tech/bus/usb/dwc

# Resolve conflicts in drivers/usb/dwc3/dwc3-qcom.c
# Edit the file to resolve conflict markers (<<<<<<, ======, >>>>>>)
# Ensure the new code is correctly integrated with any changes in the base

git add drivers/usb/dwc3/dwc3-qcom.c
git rebase --continue

# Force-push the rebased branch
git push --force-with-lease

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next

# Run automerge to create integration branch (if targeting qcom-next)
# Or checkout the topic branch directly:
git fetch origin tech/bus/usb/dwc
git checkout tech/bus/usb/dwc

# Fetch and attempt to merge the PR
git fetch https://github.com/qualcomm-linux/kernel-topics.git pull/1625/head:pr-1625
git merge --no-commit pr-1625

# Conflict will appear - inspect with:
git status
git diff drivers/usb/dwc3/dwc3-qcom.c

✅ tag-check

Status: PASS

The commit subject starts with FROMLIST:, which is a valid prefix for patches posted to the mailing list. The Link trailer is also present pointing to the lore.kernel.org thread.

Since the target branch is tech/bus/usb/dwc (not qcom-next or qcom-next-staging), the subject prefix requirement applies, and this commit correctly includes it.

Verdict

BLOCKER: Merge conflict must be resolved before checkers can run.

The PR cannot be evaluated for code quality, style, or compliance issues until the merge conflict in drivers/usb/dwc3/dwc3-qcom.c is resolved. Once the conflict is fixed and the PR is updated, the CI will need to be re-triggered to run all six checkers.

Action required: Rebase the PR on the current tech/bus/usb/dwc branch, resolve the conflict in drivers/usb/dwc3/dwc3-qcom.c, and force-push the updated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppratap-liveroot Pratham Pratap (ppratap-liveroot) Awaiting requested review from ppratap-liveroot ppratap-liveroot was automatically assigned from qualcomm-linux/kernel-tech-bus-usb-maint
@wcheng-eng wcheng-eng Awaiting requested review from wcheng-eng wcheng-eng was automatically assigned from qualcomm-linux/kernel-tech-bus-usb-maint

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kriskura176767 @qlijarvis