Skip to content

lemans: Fix duplicate cdsp_sw cooling device - #939

Open
dmantre wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:lemans-cdsp-fix
Open

lemans: Fix duplicate cdsp_sw cooling device#939
dmantre wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
dmantre:lemans-cdsp-fix

Conversation

@dmantre

@dmantre dmantre commented Aug 11, 2026

Copy link
Copy Markdown

Add a new compatible "qcom,qmi-cooling-cdsp1" with its own instance ID (0x44), and use it for cdsp1's cooling node so each CDSP gets its own distinct cooling device.

CRs-Fixed: 4553608

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; missing vendor prefix to indicate origin
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — no upstream posting found; appears to be vendor-only fix without proper QCLINUX: prefix
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream link provided
Body preserves rationale ⚠️ Brief description present but no upstream reference
Fixes tag present/correct Missing - should reference the commit that introduced the duplicate
Authorship preserved N/A No upstream to compare against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/lemans.dtsi ⚠️ Changes compatible string from qcom,qmi-cooling-cdsp to qcom,qmi-cooling-cdsp1
drivers/soc/qcom/qmi-cooling.c ⚠️ Adds new compatible and instance ID for cdsp1

Issues

  1. Missing vendor prefix: Commit lacks a prefix (QCLINUX:, UPSTREAM:, FROMLIST:, etc.) to indicate its origin and upstream status.

  2. No lore.kernel.org link: No Link: tag pointing to an upstream posting or discussion. If this is vendor-only work, it should be prefixed with QCLINUX:. If it's intended for upstream, it should be posted to the mailing list first and tagged with FROMLIST:.

  3. Missing Fixes tag: This patch fixes a duplicate cooling device issue but doesn't reference the commit that introduced the problem. A Fixes: tag should be added to help with backporting and tracking.

  4. Insufficient commit message: The description is brief and doesn't explain:

    • Why the duplicate exists (was cdsp0 using the same compatible as cdsp1?)
    • What the user-visible impact is (duplicate sysfs entries? thermal management failure?)
    • Whether this is a platform-specific workaround or a proper fix
  5. Not present in qcom-next or topics: According to integration_presence_report.md, this commit is missing from both qcom-next and all topic branches, which is expected for a new PR but confirms it hasn't been integrated yet.

Verdict

Do not merge without corrections. This patch requires:

  1. Add appropriate vendor prefix (QCLINUX: if vendor-only, or FROMLIST: if posted upstream)
  2. Add Fixes: tag referencing the commit that introduced the duplicate
  3. Expand commit message to explain the root cause and impact
  4. If intended for upstream, post to linux-arm-msm and devicetree mailing lists first

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message; missing vendor prefix to indicate origin
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — no upstream posting found; appears to be vendor-only fix without proper QCLINUX: prefix
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new PR, but confirms not yet integrated)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31507774483

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New compatible string not in binding schema
sparse-check No static analysis issues
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix
tag-check Subject prefix required for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31507774483

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New compatible string not in binding schema
sparse-check No static analysis issues
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix
tag-check Subject prefix required for qcom-6.18.y

❌ dtb-check

Root cause: The new compatible string qcom,qmi-cooling-cdsp1 is not declared in the DT binding schema.

Failure details:

lemans-evk.dtb: remoteproc@2a300000 (qcom,sa8775p-cdsp1-pas): cooling:compatible:0: 
  'qcom,qmi-cooling-cdsp1' is not one of ['qcom,qmi-cooling-modem', 'qcom,qmi-cooling-cdsp']
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml

arch/arm64/boot/dts/qcom/lemans-evk.dtb: /soc@0/remoteproc@2a300000/cooling: 
  failed to match any schema with compatible: ['qcom,qmi-cooling-cdsp1']

This error appears across multiple DTBs: lemans-evk.dtb, lemans-evk-el2.dtb, lemans-camx-el2.dtb, lemans-evk-camera-csi1-imx577.dtb, lemans-evk-camx.dtb, and all sa8775p-ride*.dtb variants.

Fix: Add qcom,qmi-cooling-cdsp1 to the DT binding schema. The binding file is likely Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml or a referenced thermal/cooling binding. Update the enum or oneOf list to include the new compatible string:

properties:
  cooling:
    properties:
      compatible:
        enum:
          - qcom,qmi-cooling-modem
          - qcom,qmi-cooling-cdsp
          - qcom,qmi-cooling-cdsp1  # Add this line

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk.dtb

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device
Commit summary does not start with a required prefix

Fix: Add a valid prefix to the commit subject. Since this is a vendor-specific fix for a duplicate cooling device issue, the appropriate prefix depends on the patch origin:

  • If this fix is posted to lore.kernel.org → use FROMLIST:
  • If this is a vendor-only fix → use QCLINUX: (note: this will still fail check-patch-compliance due to checker limitations, but is correct for vendor-only changes)
  • If this fix is already merged upstream → use UPSTREAM: or BACKPORT:

Recommended action:

git rebase -i HEAD~1   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device"
git rebase --continue

Note: The check-patch-compliance checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes. If this is a vendor-only change, the checker will continue to fail — this is a known limitation. However, the prefix is still required for all commits targeting branches other than qcom-next or qcom-next-staging.


❌ tag-check

Root cause: Target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), so every commit must have a subject prefix.

Failure details:

Commit fd09da72a082 ("arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device"): 
  subject line does not start with a required prefix.
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Same as check-patch-compliance above — add a valid prefix to the commit subject.


Verdict

2 blockers must be fixed before merge:

  1. dtb-check: Add qcom,qmi-cooling-cdsp1 to the DT binding schema (likely in Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml or a referenced cooling binding).

  2. check-patch-compliance + tag-check: Add a subject prefix (QCLINUX: recommended for vendor-only changes, or FROMLIST: if posted upstream).

Note: If this is a vendor-only change and you use QCLINUX:, the check-patch-compliance checker will still fail due to its limitation of only accepting upstream-linkable prefixes. However, the prefix is still required for the tag-check validation and for proper commit categorization in the tree.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org links found in either commit message. Commits lack required prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or QCLINUX:).

  2. Lore link matches PR commits: N/A — no lore link to compare against.

  3. Upstream patch status: Not upstream — no evidence of mailing list posting or mainline merge. These appear to be new patches that have not been submitted to the community.

  4. PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - Add CDSP1 support and fix duplicate cdsp_sw cooling
Upstream commit: N/A (no lore.kernel.org links found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream No upstream link to compare against
Body preserves rationale ⚠️ Commit 1/2 has minimal description; Commit 2/2 has brief rationale
Fixes tag present/correct No Fixes tag in either commit
Authorship preserved N/A No upstream to compare against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
drivers/soc/qcom/qmi-cooling.c ⚠️ New compatible added without dt-binding documentation reference
arch/arm64/boot/dts/qcom/lemans.dtsi ⚠️ Uses new compatible without upstream acceptance

Issues

Commit 1/2: soc: qcom: qmi-cooling: Add CDSP1 support

  1. Missing lore link: No Link: tag pointing to lore.kernel.org posting
  2. Missing commit prefix: Should have UPSTREAM:, FROMLIST:, BACKPORT:, or QCLINUX: prefix
  3. Missing Fixes tag: This appears to fix an issue (duplicate cooling devices) but has no Fixes: tag
  4. Incomplete description: Commit message doesn't explain why CDSP1 needs instance ID 0x44 or the problem being solved
  5. Missing dt-binding update: Adding a new compatible string requires corresponding dt-binding documentation

Commit 2/2: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

  1. Missing lore link: No Link: tag pointing to lore.kernel.org posting
  2. Missing commit prefix: Should have UPSTREAM:, FROMLIST:, BACKPORT:, or QCLINUX: prefix
  3. Missing Fixes tag: Subject says "Fix" but no Fixes: tag identifying what commit introduced the duplicate
  4. Dependency on unmerged change: Uses qcom,qmi-cooling-cdsp1 compatible from commit 1/2 which is not yet upstream

Verdict

Do not merge without correction. Both commits lack mandatory upstream attribution (lore links and commit prefixes). If these are vendor-only changes, they must use the QCLINUX: prefix. If they are intended for upstream, they must be posted to the mailing list first and include FROMLIST: prefix with lore links. Additionally, commit 1/2 requires dt-binding documentation updates before it can be accepted upstream.

Final Summary

  1. Lore link present: No — no lore.kernel.org links found in either commit message. Commits lack required prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or QCLINUX:).

  2. Lore link matches PR commits: N/A — no lore link to compare against.

  3. Upstream patch status: Not upstream — no evidence of mailing list posting or mainline merge. These appear to be new patches that have not been submitted to the community.

  4. PR present in qcom-next/topics: Fail — 2/2 commits are missing from both qcom-next and topics (per integration_presence_report.md). This is a validation failure as changes should be present in at least one integration branch before PR merge.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] soc: qcom: qmi-cooling: Add CDSP1 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 0/2
missing_commits: 2/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31567056921

Checker Result Summary
Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check ⏭️ No binding changes
dtb-check New compatible string not in binding schema
sparse-check No sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix on both commits
tag-check Subject prefix required (unless target is qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - soc: qcom: qmi-cooling: Add CDSP1 support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31567056921

Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check ⏭️ No binding changes
dtb-check New compatible string not in binding schema
sparse-check No sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix on both commits
tag-check Subject prefix required (unless target is qcom-next/qcom-next-staging)

❌ dtb-check

Root cause: The new compatible string qcom,qmi-cooling-cdsp1 is used in DTS but not declared in the DT binding schema.

Failure details:

lemans-evk.dtb: remoteproc@2a300000 (qcom,sa8775p-cdsp1-pas): cooling:compatible:0: 
  'qcom,qmi-cooling-cdsp1' is not one of ['qcom,qmi-cooling-modem', 'qcom,qmi-cooling-cdsp']
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml

arch/arm64/boot/dts/qcom/lemans-evk.dtb: /soc@0/remoteproc@2a300000/cooling: 
  failed to match any schema with compatible: ['qcom,qmi-cooling-cdsp1']

This error appears in multiple DTB files:

  • lemans-evk.dtb
  • lemans-evk-el2.dtb
  • lemans-camx-el2.dtb
  • lemans-evk-camera-csi1-imx577.dtb
  • lemans-evk-camx.dtb

Fix: Add the new compatible string to the DT binding schema. The binding file is likely Documentation/devicetree/bindings/thermal/qcom-qmi-cooling.yaml or referenced within Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml.

Update the binding to include qcom,qmi-cooling-cdsp1 in the compatible enum:

properties:
  compatible:
    enum:
      - qcom,qmi-cooling-modem
      - qcom,qmi-cooling-cdsp
      - qcom,qmi-cooling-cdsp1  # Add this line

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk.dtb

❌ check-patch-compliance

Root cause: Both commits lack a required subject prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: soc: qcom: qmi-cooling: Add CDSP1 support
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to each commit subject. Choose based on the patch origin:

For commit 1 (driver change):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: soc: qcom: qmi-cooling: Add CDSP1 support"
# (or use FROMLIST: if posted upstream, with Link: tag)
git rebase --continue

For commit 2 (DTS change):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling device"
git rebase --continue

Note: If these patches are vendor-only changes with no upstream equivalent, use QCLINUX:. However, be aware that check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:), so vendor-only commits will always fail this checker — this is a known limitation.

If the patches have been or will be posted upstream, use FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL.


❌ tag-check

Root cause: Subject prefix is mandatory for all branches except qcom-next and qcom-next-staging.

Applies to: Both commits in this PR.

Fix: Same as check-patch-compliance above — add a valid prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:) to each commit subject.

Note: This check is skipped if the PR targets qcom-next or qcom-next-staging. Unable to verify target branch due to network connectivity; if the target is one of those branches, this check does not apply.


Verdict

2 blockers must be fixed before merge:

  1. DT binding update required — Add qcom,qmi-cooling-cdsp1 to the thermal/remoteproc binding schema to resolve dtb-check failures.

  2. Subject prefix required — Add appropriate prefix tags (QCLINUX: for vendor-only, or FROMLIST:/UPSTREAM: with Link: if posted upstream) to both commit subjects.

Recommended workflow:

  1. Add a third commit (or amend commit 1) to update the DT binding YAML with the new compatible string.
  2. Rebase to add subject prefixes to all commits.
  3. Re-run CI to verify dtb-check and check-patch-compliance pass.

@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org Link tags found in either commit message. Per validate-patch skill Step 1, this is a FAIL condition.

  2. Lore link matches PR commits: N/A — no lore link to compare against. Cannot verify diff faithfulness to upstream.

  3. Upstream patch status: N/A — no lore link provided. Cannot determine if patches are posted, under review, accepted, or rejected upstream.

  4. PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - Add CDSP1 support and fix duplicate cdsp_sw cooling
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Commit 1/2: soc: qcom: qmi-cooling: Add CDSP1 support

Check Status Note
Subject matches upstream No upstream link to compare against
Body preserves rationale ⚠️ Rationale present but no upstream reference
Fixes tag present/correct N/A Not a fix commit
Authorship preserved No upstream author to verify against
Backport note (if applicable) N/A Not marked as backport
Commit prefix Missing required prefix (QCLINUX:/PENDING:/FROMLIST:/UPSTREAM:)

Commit 2/2: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

Check Status Note
Subject matches upstream No upstream link to compare against
Body preserves rationale ⚠️ Rationale present but no upstream reference
Fixes tag present/correct Missing - this fixes a duplicate cooling device issue
Authorship preserved No upstream author to verify against
Backport note (if applicable) N/A Not marked as backport
Commit prefix Missing required prefix (QCLINUX:/PENDING:/FROMLIST:/UPSTREAM:)

Diff

Commit 1/2:

File Status Notes
drivers/soc/qcom/qmi-cooling.c ⚠️ Cannot verify against upstream - no lore link provided

Commit 2/2:

File Status Notes
arch/arm64/boot/dts/qcom/lemans.dtsi ⚠️ Cannot verify against upstream - no lore link provided

Issues

Critical Issues:

  1. No lore.kernel.org links found - Both commits lack Link: tags pointing to lore.kernel.org. Per the validate-patch skill Step 1, this is a FAIL condition. The skill can only validate patches against lore.kernel.org sources.

  2. Missing commit prefixes - Neither commit has a required prefix:

    • No UPSTREAM: (would require lore/kernel.org link)
    • No FROMLIST: (would require lore.kernel.org link)
    • No BACKPORT: (would require lore/kernel.org link)
    • No QCLINUX: (vendor-only, no link required)
    • No PENDING: (work-in-progress, no link required)
    • No WORKAROUND: (temporary fix, no link required)
  3. Missing Fixes tag in commit 2/2 - The second commit fixes a duplicate cooling device issue but lacks a Fixes: tag to reference the commit that introduced the duplicate.

  4. Not present in qcom-next or topics - Per integration_presence_report.md, both commits (2/2) are missing from qcom-next and all topic branches. This indicates the changes have not been integrated into the Qualcomm kernel tree.

Commit Message Quality Issues:

  1. Commit 1/2 - The commit message describes adding CDSP1 support but doesn't explain:

    • Why CDSP1 needs a separate instance ID
    • What hardware/platform requires this
    • Whether this is posted upstream or vendor-specific
  2. Commit 2/2 - The commit message mentions "Fix duplicate cdsp_sw cooling" but doesn't:

    • Identify which commit introduced the duplicate
    • Explain the impact of the duplicate (does it cause functional issues?)
    • Reference the first commit as a dependency

Verdict

Do not merge without corrections. Both commits fail validation due to missing lore.kernel.org links and missing commit prefixes required by the Qualcomm kernel tree conventions.

Required actions:

  1. If these are vendor-only changes (not posted upstream):

    • Add QCLINUX: prefix to both commit subjects
    • No lore link required
    • Update commit messages to clarify this is Qualcomm-specific
  2. If these are intended for upstream:

    • Post patches to the appropriate mailing list (linux-arm-msm@vger.kernel.org)
    • Add FROMLIST: prefix to both commit subjects
    • Add Link: https://lore.kernel.org/r/<message-id> tags
    • Re-run validation after posting
  3. Add Fixes tag to commit 2/2:

    Fixes: <sha> ("commit that added duplicate cdsp cooling node")
    
  4. Improve commit messages:

    • Commit 1/2: Explain why CDSP1 needs separate instance ID
    • Commit 2/2: Explain impact of duplicate and dependency on commit 1/2

Final Summary

  1. Lore link present: No — no lore.kernel.org Link tags found in either commit message. Per validate-patch skill Step 1, this is a FAIL condition.

  2. Lore link matches PR commits: N/A — no lore link to compare against. Cannot verify diff faithfulness to upstream.

  3. Upstream patch status: N/A — no lore link provided. Cannot determine if patches are posted, under review, accepted, or rejected upstream.

  4. PR present in qcom-next/topics: Fail — 2/2 commits are missing from both qcom-next and all topic branches (per integration_presence_report.md). This indicates the changes have not been integrated into the Qualcomm kernel tree.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/2 [PATCH 1/2] soc: qcom: qmi-cooling: Add CDSP1 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/2 [PATCH 2/2] arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/2
partial_commits: 0/2
missing_commits: 2/2
topics_checked_for_commits: 2/2
final_summary: PR present in qcom-next/topics: Fail - 2/2 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31569627875

Checker Result Summary
Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check New compatible string not in binding schema
sparse-check No sparse warnings in changed code
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix on both commits
tag-check Subject prefix required (not qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - Add CDSP1 QMI cooling support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31569627875

Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check New compatible string not in binding schema
sparse-check No sparse warnings in changed code
check-uapi-headers No UAPI changes
check-patch-compliance Missing required subject prefix on both commits
tag-check Subject prefix required (not qcom-next/qcom-next-staging)

❌ dtb-check

Root cause: The new compatible string qcom,qmi-cooling-cdsp1 is not documented in the device tree binding schema.

Failure details:

arch/arm64/boot/dts/qcom/lemans-evk.dtb: /soc@0/remoteproc@2a300000/cooling: 
  failed to match any schema with compatible: ['qcom,qmi-cooling-cdsp1']

remoteproc@2a300000 (qcom,sa8775p-cdsp1-pas): cooling:compatible:0: 
  'qcom,qmi-cooling-cdsp1' is not one of ['qcom,qmi-cooling-modem', 'qcom,qmi-cooling-cdsp']
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml

This error appears across multiple DTB files: lemans-evk.dtb, lemans-evk-el2.dtb, lemans-camx-el2.dtb, qcs9100-ride-r3-el2.dtb, sa8775p-ride.dtb, and others.

Fix: Add the new compatible string to the device tree binding schema. The binding file is likely Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml (or a thermal/cooling binding that it references). Update the enum to include:

properties:
  cooling:
    properties:
      compatible:
        enum:
          - qcom,qmi-cooling-modem
          - qcom,qmi-cooling-cdsp
          - qcom,qmi-cooling-cdsp1  # Add this line

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/lemans-evk.dtb

❌ check-patch-compliance

Root cause: Both commits lack the required subject prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, etc.).

Failure details:

Checking commit: soc: qcom: qmi-cooling: Add CDSP1 support
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling
Commit summary does not start with a required prefix

Fix: Add an appropriate prefix to each commit subject line:

Commit 1: 3d166cc699e8 - "soc: qcom: qmi-cooling: Add CDSP1 support"

git rebase -i HEAD~2
# Mark first commit as 'edit'
git commit --amend -m "QCLINUX: soc: qcom: qmi-cooling: Add CDSP1 support"
# (keep the rest of the commit message)
git rebase --continue

Commit 2: 1b0410fa1e4b - "arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"

# Mark second commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"
# (keep the rest of the commit message)
git rebase --continue

Note: Use QCLINUX: if this is a vendor-specific change with no upstream equivalent. If this work has been or will be posted upstream, use FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL.

Reproduce locally:

# From kernel-checkers repo
./check-patch-compliance.sh

❌ tag-check

Root cause: Both commits are missing the mandatory subject prefix required for all branches except qcom-next and qcom-next-staging.

Failure details:

Based on the integration presence report showing these commits are NOT in qcom-next, and the checker failure pattern, this PR is targeting a branch that requires subject prefixes.

Commit 1: 3d166cc699e8 - "soc: qcom: qmi-cooling: Add CDSP1 support"
❌ Subject line does not start with a required prefix.

Commit 2: 1b0410fa1e4b - "arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"
❌ Subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: - Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: - Patch taken from a maintainer git tree
  • UPSTREAM: - Patch merged into Linus's mainline tree
  • BACKPORT: - Upstream patch backported with modifications
  • QCLINUX: - Vendor-only change with no upstream equivalent
  • PENDING: - Work-in-progress, not yet posted upstream
  • WORKAROUND: - Temporary fix not suitable for upstream

Fix: Same as check-patch-compliance fix above - add the appropriate prefix to both commit subjects.


Verdict

3 blockers must be fixed before merge:

  1. Add DT binding documentation for qcom,qmi-cooling-cdsp1 to fix dtb-check failures
  2. Add subject prefix to commit 1: "soc: qcom: qmi-cooling: Add CDSP1 support"
  3. Add subject prefix to commit 2: "arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"

Recommended workflow:

  1. Add the new compatible string to the appropriate DT binding YAML file (likely in Documentation/devicetree/bindings/remoteproc/ or a thermal/cooling binding)
  2. Rebase the two commits to add QCLINUX: prefix (or FROMLIST: if posting upstream)
  3. Re-run CI to verify all checkers pass

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@dmantre
dmantre force-pushed the lemans-cdsp-fix branch 2 times, most recently from f414eb2 to ead4076 Compare August 12, 2026 08:32
…g-cdsp1

Document the qcom,qmi-cooling-cdsp1 compatible.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-1-b15d47adc379@oss.qualcomm.com/
Add a new compatible "qcom,qmi-cooling-cdsp1" with its own instance ID
(0x44), and use it for cdsp1's cooling node so each CDSP gets its own
distinct cooling device.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-2-b15d47adc379@oss.qualcomm.com/
Use the CDSP1 compatible string for the second node so
that each CDSP gets its own cooling device.

Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-6-b15d47adc379@oss.qualcomm.com/
@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - but all three links are WRONG
  2. Lore link matches PR commits: No - PR content is about qmi-cooling bindings/driver; lore links point to remoteproc TMD patches from a completely different series
  3. Upstream patch status: Cannot determine - wrong lore links provided
  4. PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - FROMLIST: Add qcom,qmi-cooling-cdsp1 support
Upstream commits: Multiple lore links provided
Verdict: ❌ FAIL

Critical Issue: Wrong Lore Links

The PR commits link to patches from the series "[PATCH v8 0/9] Add support for Qualcomm remoteproc subsystem cooling" but the PR content does NOT match those patches at all.

Lore series (20260809-b4-qmi-tmd-v8) contains:

  • Patch 1/9: "dt-bindings: remoteproc: qcom,pas: add #cooling-cells property"
  • Patch 2/9: "soc: qcom: Add QMI TMD support for remote thermal"
  • Patch 6/9: "arm64: dts: qcom: lemans: Enable CDSP cooling" (adds cooling-maps to remoteproc nodes)

PR commits claim to be:

  • Patch 1: "dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1"
  • Patch 2: "soc: qcom: qmi-cooling: Add CDSP1 support"
  • Patch 3: "arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"

Commit Message

Check Status Note
Subject matches upstream Subjects completely different - wrong lore links
Body preserves rationale Cannot verify - lore links point to wrong patches
Fixes tag present/correct N/A No Fixes tag in PR or lore
Authorship preserved ⚠️ Author changed from Gaurav Kohli to Dipa Ramesh Mantre
Backport note (if applicable) N/A FROMLIST prefix used

Diff

File Status Notes
Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml File not touched in linked lore patches
drivers/soc/qcom/qmi-cooling.c File not touched in linked lore patches
arch/arm64/boot/dts/qcom/lemans.dtsi PR changes compatible string; lore patch 6/9 adds cooling-maps - completely different changes

Issues

  1. Wrong lore message IDs: All three PR commits link to patches from the "remoteproc subsystem cooling" series, but the PR content is about "qmi-cooling" device bindings and driver changes. These are unrelated patch series.

  2. Author mismatch: The lore series author is Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>, but the PR commits show Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com> as author. For FROMLIST commits, the original author's Signed-off-by should be present, but it's missing.

  3. Subject mismatch:

    • PR patch 1 subject mentions "qcom,qmi-cooling" bindings, but lore patch 1/9 is about "qcom,pas" remoteproc bindings
    • PR patch 2 subject mentions "qmi-cooling" driver, but lore patch 2/9 is about "QMI TMD" support
    • PR patch 3 subject mentions "Fix duplicate cdsp_sw", but lore patch 6/9 is about "Enable CDSP cooling"
  4. File path mismatch:

    • PR touches qcom,qmi-cooling.yaml and qmi-cooling.c - these files are NOT modified in the linked lore patches
    • Lore patches touch qcom,pas-common.yaml, add new TMD driver files, and modify remoteproc drivers
  5. Diff content mismatch: The PR changes are structurally incompatible with the lore patches - they modify completely different subsystems (thermal/qmi-cooling vs remoteproc/TMD).

Verdict

DO NOT MERGE - The lore links are completely wrong. The PR appears to be from a different patch series that is not linked in the commit messages. The correct lore links must be found and added before this PR can be validated.

Recommendation

  1. Find the correct lore.kernel.org links for these qmi-cooling patches (search for "qcom,qmi-cooling-cdsp1" on lore)
  2. Update all three commit messages with the correct Link: tags
  3. Verify the original author (should be in From: or have their Signed-off-by: present)
  4. Re-submit the PR with corrected commit messages

Final Summary

  1. Lore link present: Yes - but all three links are WRONG
  2. Lore link matches PR commits: No - PR content is about qmi-cooling bindings/driver; lore links point to remoteproc TMD patches from a completely different series
  3. Upstream patch status: Cannot determine - wrong lore links provided
  4. PR present in qcom-next/topics: No - per integration_presence_report.md, all 3 commits missing from both qcom-next and topics

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/3 [PATCH 1/3] FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/3 [PATCH 2/3] FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/3 [PATCH 3/3] FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/3
partial_commits: 0/3
missing_commits: 3/3
topics_checked_for_commits: 3/3
final_summary: PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31575094903

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: DT binding split required
dt-binding-check Passed
dtb-check Passed
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 2 commits missing required prefix
tag-check 2 commits missing FROMLIST: prefix in git tree

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - Add CDSP1 support to qmi-cooling and fix lemans DTS
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31575094903

Checker Result Summary
checkpatch 1 warning: DT binding split required
dt-binding-check Passed
dtb-check Passed
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance 2 commits missing required prefix
tag-check 2 commits missing FROMLIST: prefix in git tree

❌ checkpatch

Root cause: Commit 7274bf6 includes both DT binding changes and driver code changes in a single patch.

Failure details:

Commit 7274bf6425e7 ("soc: qcom: qmi-cooling: Add CDSP1 support")
WARNING: DT binding docs and includes should be a separate patch. 
See: Documentation/devicetree/bindings/submitting-patches.rst
7274bf6425e74aa26198bdc213ac28409a426b44 total: 0 errors, 1 warnings, 0 checks, 45 lines checked

Fix: Split the patch into two separate commits:

  1. First commit: DT binding changes only (Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml and include/dt-bindings/thermal/qcom,qmi-cooling.h)
  2. Second commit: Driver implementation (drivers/soc/qcom/qmi_cooling.c)

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8635749eab9a..69354dffcaa8

❌ check-patch-compliance

Root cause: Two commits in the git tree are missing the required FROMLIST: prefix in their subject lines.

Failure details:

Checking commit: soc: qcom: qmi-cooling: Add CDSP1 support
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling
Commit summary does not start with a required prefix

Analysis: The patch file (pr.patch) shows all 3 commits have FROMLIST: prefix:

  • FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add ...
  • FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support
  • FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

However, the checker is seeing commits in the git tree without the prefix:

  • soc: qcom: qmi-cooling: Add CDSP1 support (missing FROMLIST:)
  • arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling (missing FROMLIST:)

Note: The first commit (dt-bindings) was not checked by check-patch-compliance, which only checked 2 of the 3 commits.

Fix: Amend the commit messages in the git tree to include the FROMLIST: prefix:

# Interactive rebase to edit commits
git rebase -i 8635749eab9a

# For each commit marked as 'edit':
git commit --amend -m "FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support"
# (keep the rest of the commit message body unchanged)
git rebase --continue

# Repeat for the second commit:
git commit --amend -m "FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"
git rebase --continue

Required prefix tags: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:


❌ tag-check

Root cause: Same as check-patch-compliance — commits in the git tree are missing the mandatory subject-line prefix.

Failure details:
The following commits do not start with a required prefix:

  • Commit 7274bf6: soc: qcom: qmi-cooling: Add CDSP1 support
  • Commit 69354df: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

Note: This check applies to all branches except qcom-next and qcom-next-staging. Based on the checker run, the target branch appears to require prefix tags.

Fix: Same as check-patch-compliance above — add FROMLIST: prefix to both commit subjects.


Verdict

3 blockers must be fixed before merge:

  1. Split the DT binding patch — Separate the binding changes from the driver code (checkpatch warning)
  2. Add FROMLIST: prefix to commit 2soc: qcom: qmi-cooling: Add CDSP1 support
  3. Add FROMLIST: prefix to commit 3arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

Root cause summary: The patch file shows correct FROMLIST: prefixes, but the actual git commits in the PR branch do not have these prefixes. This suggests the commits were created or amended without the prefix, even though the patch export includes them.

Recommended action:

  1. Rebase interactively to split the binding patch into a separate commit
  2. Amend all commit messages to ensure FROMLIST: prefix is in the actual git commit subject (not just the patch file)
  3. Force-push the corrected branch
  4. Re-trigger CI

@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
3 Full report

Final Summary

  1. Lore link present: Yes — but links point to wrong patches (remoteproc/QMI TMD series instead of qmi-cooling changes)
  2. Lore link matches PR commits:No — complete subject/file/content mismatch across all three commits
  3. Upstream patch status:Unknown — the linked lore patches are ACKed, but they are unrelated to the PR content; actual upstream status of the qmi-cooling patches cannot be determined
  4. PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - "FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1" (3 commits)
Upstream commit: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-1-b15d47adc379@oss.qualcomm.com/ (and related)
Verdict:FAIL


Commit Message

Check Status Note
Subject matches upstream Complete mismatch — PR subjects reference qcom,qmi-cooling driver; lore subjects reference remoteproc: qcom,pas and QMI TMD
Body preserves rationale Cannot verify — lore patches are for a different subsystem
Fixes tag present/correct N/A No Fixes tags in PR or lore
Authorship preserved ⚠️ From: is Dipa Ramesh Mantre in both PR and lore, but patches are unrelated
Backport note (if applicable) N/A FROMLIST: prefix used (not a backport)

Diff

File Status Notes
Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml PR modifies this file; lore patch 1/9 modifies remoteproc/qcom,pas-common.yaml — completely different files
drivers/soc/qcom/qmi-cooling.c PR modifies this file; lore patch 2/9 adds new file drivers/soc/qcom/qmi_tmd.c — completely different changes
arch/arm64/boot/dts/qcom/lemans.dtsi PR changes qcom,qmi-cooling-cdspqcom,qmi-cooling-cdsp1; lore patch 6/9 adds new cooling node with #cooling-cells — completely different changes

Issues

Critical: Incorrect lore links

The PR commits reference lore.kernel.org message IDs from a completely different patch series:

  • PR commit 1/3: Claims to add qcom,qmi-cooling-cdsp1 compatible to Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml
    Lore patch v8 1/9: Actually adds #cooling-cells property to Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml and introduces include/dt-bindings/thermal/qcom,pas.h

  • PR commit 2/3: Claims to add CDSP1 support to drivers/soc/qcom/qmi-cooling.c
    Lore patch v8 2/9: Actually introduces a new driver drivers/soc/qcom/qmi_tmd.c for QMI TMD (Thermal Mitigation Device) support

  • PR commit 3/3: Claims to fix duplicate cdsp_sw cooling by changing compatible string
    Lore patch v8 6/9: Actually enables CDSP cooling by adding a new cooling subnode with #cooling-cells = <3>

The lore series (v8 0/9) is titled "Add support for Qualcomm remoteproc subsystem cooling" and introduces a new QMI TMD framework for remoteproc thermal management. The PR patches are about extending an existing qmi-cooling driver with a new cdsp1 compatible. These are entirely different features.

Root cause: The PR author appears to have copied message IDs from an unrelated patch series. The correct lore links for these qmi-cooling patches do not exist in the provided evidence, suggesting either:

  1. The patches were never posted to lore.kernel.org, or
  2. They were posted under different message IDs that are not referenced in the PR

Upstream Patch Status

Commit Community Verdict
v8 1/9 (remoteproc: qcom,pas) ✅ ACKed — Reviewed-by: Krzysztof Kozlowski, Acked-by: Daniel Lezcano
v8 2/9 (QMI TMD driver) ✅ ACKed — Reviewed-by: Daniel Lezcano
v8 6/9 (lemans: Enable CDSP cooling) ✅ ACKed — Reviewed-by: Dmitry Baryshkov, Daniel Lezcano

Note: The upstream status above applies to the lore patches at the linked message IDs, not the PR patches. Since the PR patches do not match the lore patches, the upstream acceptance status is unknown for the actual PR content.


qcom-next Presence

Per integration_presence_report.md:

Commit Status
1/3 (dt-bindings: thermal: qcom,qmi-cooling) ⚠️ Not in qcom-next — missing from both qcom-next (49dbe0d) and topics
2/3 (soc: qcom: qmi-cooling: Add CDSP1) ⚠️ Not in qcom-next — missing from both qcom-next and topics
3/3 (arm64: dts: qcom: lemans: Fix duplicate) ⚠️ Not in qcom-next — missing from both qcom-next and topics

Overall: 0/3 commits present in qcom-next or topics.


Verdict

❌ DO NOT MERGE

This PR has incorrect lore.kernel.org links. The referenced message IDs point to a remoteproc/QMI TMD patch series that is completely unrelated to the PR's actual content (qmi-cooling driver changes). This violates the fundamental requirement of the FROMLIST: prefix, which mandates that the Link: tag must point to the actual upstream posting of the patch.

Required actions before merge:

  1. Verify upstream posting: Confirm whether these qmi-cooling patches were actually posted to lore.kernel.org. If yes, update the Link: tags with the correct message IDs.

  2. If not posted upstream: Change the prefix from FROMLIST: to PENDING: or QCLINUX: depending on intent, and remove the lore links.

  3. If these are backports of accepted patches: Change prefix to UPSTREAM: or BACKPORT: and link to the merged kernel.org commits.

  4. Verify qcom-next presence: All three commits are missing from qcom-next and topics. If these are intended for integration, they should be present in at least one topic branch before merging to qcom-next.


Final Summary

  1. Lore link present: Yes — but links point to wrong patches (remoteproc/QMI TMD series instead of qmi-cooling changes)
  2. Lore link matches PR commits:No — complete subject/file/content mismatch across all three commits
  3. Upstream patch status:Unknown — the linked lore patches are ACKed, but they are unrelated to the PR content; actual upstream status of the qmi-cooling patches cannot be determined
  4. PR present in qcom-next/topics:Fail — 3/3 commits missing from both qcom-next (49dbe0d) and all topic branches

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/3 [PATCH 1/3] FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/3 [PATCH 2/3] FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/3 [PATCH 3/3] FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/3
partial_commits: 0/3
missing_commits: 3/3
topics_checked_for_commits: 3/3
final_summary: PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31578988755

Checker Result Summary
Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check Binding validation passed
dtb-check DTB validation passed
sparse-check No sparse warnings
check-uapi-headers No UAPI changes detected
check-patch-compliance 3 commits missing required prefix
tag-check Subject prefix required (assuming non-qcom-next branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31578988755

Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check Binding validation passed
dtb-check DTB validation passed
sparse-check No sparse warnings
check-uapi-headers No UAPI changes detected
check-patch-compliance 3 commits missing required prefix
tag-check Subject prefix required (assuming non-qcom-next branch)

❌ check-patch-compliance

Root cause: All three commits in the PR are missing the required subject-line prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1
Commit summary does not start with a required prefix

Checking commit: soc: qcom: qmi-cooling: Add CDSP1 support
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling
Commit summary does not start with a required prefix

Analysis:

The checker detected that the actual git commit subjects in the PR branch do not contain the FROMLIST: prefix, even though:

  1. The commits have Link: trailers pointing to lore.kernel.org
  2. The patch file (pr.patch) shows FROMLIST: in the subjects

This indicates a mismatch between the patch file and the actual git commits in the PR branch. The git commits need to be amended to include the prefix.

Affected commits:

  • c5ad079e8a5b - "dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1"
  • 66011d9573a7 - "soc: qcom: qmi-cooling: Add CDSP1 support"
  • ead4076343a8 - "arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"

Fix:

Each commit subject must start with FROMLIST: since these patches are posted to the mailing list (as evidenced by the Link: trailers).

# Rebase and amend each commit
git rebase -i <base_sha>   # mark each commit as 'edit'

# For each commit:
git commit --amend -m "FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1"
git rebase --continue

git commit --amend -m "FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support"
git rebase --continue

git commit --amend -m "FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling"
git rebase --continue

# Force push the updated branch
git push --force-with-lease

Reproduce locally:

cd kernel
git log 8635749eab9a..ead4076343a8 --format="%H %s"
# Verify each subject starts with FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:

❌ tag-check

Root cause: Same as check-patch-compliance — commits lack the required subject-line prefix.

Note: This check applies if the PR target branch is not qcom-next or qcom-next-staging. Based on the check-patch-compliance enforcement, this PR is likely targeting a stable/release branch that requires prefixes.

Fix: Same as above — add FROMLIST: prefix to all three commit subjects.


Verdict

3 blockers must be fixed before merge:

All three commits need their subject lines amended to include the FROMLIST: prefix. The commits are otherwise clean:

  • ✅ No checkpatch style issues
  • ✅ DT binding schema is valid
  • ✅ No DTB validation errors
  • ✅ No sparse warnings
  • ✅ No UAPI changes
  • ✅ Commits have proper Link: trailers pointing to lore.kernel.org

Once the subject prefixes are added, all checkers should pass.

@gauravkohli1

Copy link
Copy Markdown

LGTM, as this series is backported to 2.0

@qlijarvis

Copy link
Copy Markdown

PR #939 — validate-patch

PR: #939

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — but links point to wrong patch series (remoteproc QMI TMD, not qmi-cooling CDSP1)
  2. Lore link matches PR commits:No — zero file overlap; PR modifies qmi-cooling.{yaml,c}, lore modifies qcom,pas-common.yaml and introduces new qmi_tmd.c driver
  3. Upstream patch status: N/A — linked lore series has positive reviews (Acked-by Daniel Lezcano, Reviewed-by Krzysztof Kozlowski), but is unrelated to PR content
  4. PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

Root cause: The PR appears to be vendor-specific work to extend the existing qmi-cooling driver, but was incorrectly tagged as FROMLIST: with links to an unrelated upstream patch series about a new qmi_tmd driver for remoteproc thermal management.

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #939 - Add CDSP1 support to qmi-cooling driver
Upstream commit: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-1-b15d47adc379@oss.qualcomm.com/ (and related)
Verdict:FAIL


Critical Issue: Lore Links Do Not Match PR Content

The PR contains three commits that claim to be FROMLIST: patches with lore.kernel.org links, but the linked lore patches are completely different from the PR content.

What the PR changes:

  • Documentation/devicetree/bindings/thermal/qcom,qmi-cooling.yaml — adds qcom,qmi-cooling-cdsp1 compatible
  • drivers/soc/qcom/qmi-cooling.c — adds CDSP1 instance ID (0x44) support
  • arch/arm64/boot/dts/qcom/lemans.dtsi — uses new cdsp1 compatible

What the lore patches change:

  • Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml — adds #cooling-cells property
  • drivers/soc/qcom/qmi_tmd.cnew driver for QMI Thermal Mitigation Device
  • include/dt-bindings/thermal/qcom,pas.hnew header for PAS cooling device indices
  • Multiple remoteproc and thermal subsystem files

These are two entirely different patch series:

  1. PR content: Extends the existing qmi-cooling driver (in-tree since ~2020) to support a second CDSP instance
  2. Lore links: Introduce a new qmi_tmd driver for remoteproc-based thermal management via QMI

Commit Message

Check Status Note
Subject matches upstream PR: "qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1" vs Lore: "remoteproc: qcom,pas: add #cooling-cells property"
Body preserves rationale PR body is minimal; lore patch has detailed remoteproc thermal architecture explanation
Fixes tag present/correct N/A Neither PR nor lore patches have Fixes tags (new feature, not a fix)
Authorship preserved PR author: Dipa Ramesh Mantre; Lore author: Gaurav Kohli
Backport note (if applicable) N/A Marked as FROMLIST: but content doesn't match lore

Diff

File Status Notes
qcom,qmi-cooling.yaml PR modifies this file; lore patch does not touch it at all
qmi-cooling.c PR modifies this file; lore patch does not touch it at all
lemans.dtsi PR modifies cooling node; lore patch adds entirely different nodes

File path comparison:

PR patches touch Lore patches touch
thermal/qcom,qmi-cooling.yaml remoteproc/qcom,pas-common.yaml
drivers/soc/qcom/qmi-cooling.c drivers/soc/qcom/qmi_tmd.c (new file)
arch/arm64/boot/dts/qcom/lemans.dtsi include/dt-bindings/thermal/qcom,pas.h (new file)

Zero file overlap between PR and lore patches.


Upstream Patch Status

The lore series (v8, posted 2026-08-09) has received positive review signals:

  • ✅ Reviewed-by: Krzysztof Kozlowski
  • ✅ Acked-by: Daniel Lezcano
  • ✅ Reviewed-by: Daniel Lezcano (multiple patches)

However, this status is irrelevant because the lore patches are not the same as the PR patches.


Issues Found

  1. Wrong lore links — All three commits link to patches from the "Add support for Qualcomm remoteproc subsystem cooling" series (v8), but the PR content is unrelated to that series.

  2. Authorship mismatch — PR commits are authored by Dipa Ramesh Mantre, but the linked lore series is authored by Gaurav Kohli. For FROMLIST: commits, the original author's Signed-off-by: must be present. The PR commits only have Dipa's SOB, not Gaurav's.

  3. File path mismatch — The PR modifies qcom,qmi-cooling.yaml (existing thermal driver binding) while the lore patches modify qcom,pas-common.yaml (remoteproc binding). These are different subsystems.

  4. Driver mismatch — The PR modifies qmi-cooling.c (existing driver) while the lore patches introduce qmi_tmd.c (new driver). These are different drivers with different purposes.

  5. Incomplete commit message — The PR commit messages are minimal (one sentence each) and don't explain:

    • Why CDSP1 support is needed
    • What hardware requires this
    • How this differs from the existing CDSP support
    • Whether this is a new feature or fixing a bug

Recommendation

Do not merge. The PR must be corrected before it can be accepted:

  1. Find the correct lore links — Search lore.kernel.org for patches that actually add qcom,qmi-cooling-cdsp1 support. If no such patches exist upstream, the commits should be prefixed with QCLINUX: or PENDING: instead of FROMLIST:.

  2. Fix authorship — If these are truly from an upstream posting:

    • Update Link: tags to point to the correct lore thread
    • Ensure the original author's Signed-off-by: is present
    • Consider whether From: should be the original author (for UPSTREAM:/BACKPORT:) or the submitter (for FROMLIST:)
  3. Expand commit messages — Add context about:

    • Which SoC/platform needs CDSP1 support
    • Why a separate instance ID (0x44) is required
    • How this relates to the existing CDSP cooling device
  4. Verify integration presence — Per integration_presence_report.md, all three commits are missing from both qcom-next and topics. If these are vendor-specific changes not posted upstream, use QCLINUX: prefix instead of FROMLIST:.


Final Summary

  1. Lore link present: Yes — but links point to wrong patch series (remoteproc QMI TMD, not qmi-cooling CDSP1)
  2. Lore link matches PR commits:No — zero file overlap; PR modifies qmi-cooling.{yaml,c}, lore modifies qcom,pas-common.yaml and introduces new qmi_tmd.c driver
  3. Upstream patch status: N/A — linked lore series has positive reviews (Acked-by Daniel Lezcano, Reviewed-by Krzysztof Kozlowski), but is unrelated to PR content
  4. PR present in qcom-next/topics:Fail — 3/3 commits missing from both qcom-next and topics (per integration_presence_report.md)

Root cause: The PR appears to be vendor-specific work to extend the existing qmi-cooling driver, but was incorrectly tagged as FROMLIST: with links to an unrelated upstream patch series about a new qmi_tmd driver for remoteproc thermal management.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 49dbe0dae5cfb7a1eb3434cde6fc7ba37924fe94
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/3 [PATCH 1/3] FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/3 [PATCH 2/3] FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/3 [PATCH 3/3] FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/3
partial_commits: 0/3
missing_commits: 3/3
topics_checked_for_commits: 3/3
final_summary: PR present in qcom-next/topics: Fail - 3/3 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #939 — checker-log-analyzer

PR: #939
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/31589383297

Checker Result Summary
Checker Result Summary
checkpatch All 3 commits passed
dt-binding-check Binding validation passed
dtb-check No new DTB errors
sparse-check No new sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance 3 commits: content mismatch + author mismatch
tag-check ⚠️ Cannot determine (depends on target branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #939 - Add CDSP1 support to qmi-cooling
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/31589383297

Checker Result Summary
checkpatch All 3 commits passed
dt-binding-check Binding validation passed
dtb-check No new DTB errors
sparse-check No new sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance 3 commits: content mismatch + author mismatch
tag-check ⚠️ Cannot determine (depends on target branch)

❌ check-patch-compliance

Root cause: All 3 commits have both content differences from upstream lore patches and author mismatches.

Failure details:

Commit 1: FROMLIST: dt-bindings: thermal: qcom,qmi-cooling: Add qcom,qmi-cooling-cdsp1

Change is different from the one mentioned in Link
Author mismatch:
  Original author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
  Commit author : Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-1-b15d47adc379@oss.qualcomm.com/

Commit 2: FROMLIST: soc: qcom: qmi-cooling: Add CDSP1 support

Change is different from the one mentioned in Link
Author mismatch:
  Original author: Casey Connolly <casey.connolly@linaro.org>
  Commit author : Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-2-b15d47adc379@oss.qualcomm.com/

Commit 3: FROMLIST: arm64: dts: qcom: lemans: Fix duplicate cdsp_sw cooling

Change is different from the one mentioned in Link
Author mismatch:
  Original author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
  Commit author : Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-6-b15d47adc379@oss.qualcomm.com/

Analysis:

  1. Author mismatch: The commits in this PR are authored by Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>, but the upstream lore patches were authored by different people (Gaurav Kohli for commits 1 & 3, Casey Connolly for commit 2). This is a blocker.

  2. Content mismatch: The checker detected differences between the PR patches and the upstream lore patches. Visible differences include:

    • Commit 2: Indentation issue in drivers/soc/qcom/qmi-cooling.c — the new code block uses spaces instead of tabs (line + .compatible = "qcom,qmi-cooling-cdsp1", has mixed indentation)
    • There may be other context-line differences that need verification

Fix:

For author mismatch:

# For each commit, amend the author to match the upstream patch
git rebase -i <base_sha>   # mark each commit as 'edit'

# Commit 1 & 3:
git commit --amend --author="Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>"

# Commit 2:
git commit --amend --author="Casey Connolly <casey.connolly@linaro.org>"

git rebase --continue

For content mismatch:

# Fetch the upstream patches to compare
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-1-b15d47adc379@oss.qualcomm.com/ -o /tmp/patch1
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-2-b15d47adc379@oss.qualcomm.com/ -o /tmp/patch2
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260809-b4-qmi-tmd-v8-6-b15d47adc379@oss.qualcomm.com/ -o /tmp/patch3

# Compare the diffs line-by-line
diff -u <(git format-patch -1 865b5266279f --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
        <(awk '/^diff/,/^--$/' /tmp/patch1/*.mbx | grep -E '^[+-][^+-]')

# Fix any differences (especially the indentation issue in commit 2)
git rebase -i <base_sha>   # mark commit 2 as 'edit'
# Fix the indentation: replace spaces with tabs in the CDSP1 block
sed -i 's/^	       /\t/' drivers/soc/qcom/qmi-cooling.c
git add drivers/soc/qcom/qmi-cooling.c
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 8635749eab9a --head efe2237db80d

⚠️ tag-check

Status: Cannot determine without knowing the target branch.

Context: The tag-check is mandatory for all branches except qcom-next and qcom-next-staging. All 3 commits in this PR use the FROMLIST: prefix, which is valid.

  • If the target branch is qcom-next or qcom-next-staging → ✅ PASS (check not required)
  • If the target branch is any other branch → ✅ PASS (all commits have valid FROMLIST: prefix)

Verdict

3 blockers must be fixed before merge:

  1. Author mismatch on all 3 commits — must match the upstream lore patch authors (Gaurav Kohli for commits 1 & 3, Casey Connolly for commit 2)
  2. Content mismatch on all 3 commits — must verify and fix any differences from upstream, especially the indentation issue in commit 2
  3. Indentation bug in commit 2CDSP1_INSTANCE_ID block uses spaces instead of tabs

All other checkers passed cleanly. Once the author and content issues are resolved, this PR will be ready to merge.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4553608 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4553608
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants