add NVMe as a valid disk type in gen_partition.py #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkraleti
requested review from
lumag,
ndechesne and
sbanerjee-quic
as code owners
Renamed functions to better reflect their purpose: - `generate_ptool_xml` → `generate_single_disk_xml` - `generate_ufs_xml` → `generate_multi_lun_xml` - `generate_nand_mbn_gen_xml` → Dropped as unused These changes have no functional impact. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
NVMe flashing follows the same process as eMMC. Add `nvme` as a valid disk type to explicitly call out the supported storage options. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
ricardosalveti
approved these changes
Nov 13, 2025
lumag
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVMe flashing follows the same process as eMMC. Add
nvmeas a validdisk type to explicitly call out the supported storage options.