platforms: add partitions for iq-x7181-evk nvme and spinor #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Type should be nvme, but it depends on #51. Final device name will probably also be renamed, once publicly available. |
ricardosalveti
force-pushed
the
hamoa-dev
branch
from
8c0c176 to
5336e2a
Compare
ricardosalveti
changed the title
ricardosalveti
force-pushed
the
hamoa-dev
branch
from
85cdcbf to
2d81cad
Compare
lumag
requested changes
Nov 13, 2025
ricardosalveti
force-pushed
the
hamoa-dev
branch
3 times, most recently
from
9546f37 to
3456037
Compare
Contributor
|
Please rebase. LGTM otherwise. |
ricardosalveti
force-pushed
the
hamoa-dev
branch
from
3456037 to
a094131
Compare
Contributor
Author
Done. |
lumag
previously approved these changes
Nov 13, 2025
ricardosalveti
force-pushed
the
hamoa-dev
branch
from
a094131 to
cc5265d
Compare
ricardosalveti
changed the title
Contributor
Author
|
Updated to reflect the public evk commercial name: iq-x7181-evk. |
ricardosalveti
requested review from
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
shoudil
reviewed
Nov 14, 2025
Contributor
|
@ricardosalveti I've merged #51, please rebase |
Add 'spinor' as a valid disk type, following the same process for partition generation as used with emmc and nvme (single_disk_xml). Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
The parameter --grow-last-partition does not accept any argument and it supposed to be used to set GROW_LAST_PARTITION_TO_FILL_DISK to true, but since GROW_LAST_PARTITION_TO_FILL_DISK is already true by default, there is no current way to set it to false. Since all current machines are using --grow-last-partition at their partitions.conf definition, switch GROW_LAST_PARTITION_TO_FILL_DISK default to false. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Cosmetic changes only. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Add additional files which are used by iq-x7181-evk spinor boot firmware files. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Based on https://softwarecenter.qualcomm.com/nexus/generic/software/chip/ubuntu_qualcomm_iot-spf-1-0/ubuntu-qualcomm-iot-spf-1-0_test_device_public/r1.0_00001.0/hamoa_iot-ubun-1-0/HAMOA_bootbinaries.zip but with WLAN_FW and WLAN_FW_BACKUP removed, as they are not used. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
NVME partition definition can be aligned with SystemReady, which implies only ESP + rootfs. Boot firmware is provided via spinor. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
ricardosalveti
force-pushed
the
hamoa-dev
branch
from
cc5265d to
fdbacf0
Compare
Contributor
Author
Done. |
lumag
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVME partition definition can be aligned with SystemReady, which implies only ESP + rootfs.
Boot firmware is provided via spinor.