video-driver: monaco: split context banks and attach to iommu - #145
Merged
vgarodia merged 1 commit intoAug 27, 2026
Merged
Conversation
gouravk-qualcomm
force-pushed
the
iommu-fix
branch
3 times, most recently
from
August 27, 2026 10:15
745b5dd to
086b239
Compare
gouravk-qualcomm
changed the title
gouravk-qualcomm
force-pushed
the
iommu-fix
branch
from
August 27, 2026 10:22
086b239 to
4b9ec2f
Compare
vgarodia
reviewed
Aug 27, 2026
| MSM_VIDC_NON_SECURE | MSM_VIDC_NON_SECURE_BITSTREAM, 0}, | ||
| {"qcom,vidc,cb-ns-pxl", 0x00100000, 0xdff00000, 0, 1, | ||
| MSM_VIDC_NON_SECURE_PIXEL, 0}, | ||
| {"qcom,vidc,cb-sec-non-pxl", 0x01400000, 0x24400000, 1, 0, |
Contributor
There was a problem hiding this comment.
0x01400000 -> 0x01000000
0x24400000 -> 0x24800000
Contributor
Author
There was a problem hiding this comment.
thanks ,
cb-sec-non-pxl changed to 0x01000000 / 0x24800000.
vgarodia
requested changes
Aug 27, 2026
The context-bank table declared a single combined non-secure bank and relied on the parent video-codec device's iommu domain already being attached, causing msm_vidc_probe_without_context_bank to fail with "Failed to get iommu domain for aa00000.video-codec". Split the non-secure bank into separate bitstream and pixel entries and add msm_vidc_monaco_init_cb_devs() to create a dedicated child device for each, explicitly attaching it to its own iommu entry. The secure bank is intentionally left unmapped. Signed-off-by: Gourav Kumar <gouravk@qti.qualcomm.com>
gouravk-qualcomm
force-pushed
the
iommu-fix
branch
from
August 27, 2026 10:47
4b9ec2f to
d0dedde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monaco's context-bank table declared a single combined non-secure bank
and relied on the parent video-codec platform device's iommu domain
already being attached. This caused msm_vidc_probe_without_context_bank
to fail with "Failed to get iommu domain for aa00000.video-codec", which
in turn failed the component master bind and video-codec probe.
Split the non-secure bank into separate bitstream (qcom,vidc,cb-ns) and
pixel (qcom,vidc,cb-ns-pxl) entries, matching monaco.dtsi's non-pixel/
pixel context-bank subnodes. Add msm_vidc_monaco_init_cb_devs(), wired
via .init_cb_devs, to create a dedicated child device per bank and
explicitly attach each to its own iommu entry. The secure bank
(qcom,vidc,cb-sec-non-pxl) is intentionally left unmapped.
The cb-ns-pxl and cb-sec-non-pxl address ranges are carried over from
the equivalent lemans split, since monaco's original combined-row values
were identical to lemans's pre-split values.
Signed-off-by: Gourav Kumar gouravk@qti.qualcomm.com