Apm release v1.0 - #2
Closed
Dinesh D (ddhanara) wants to merge 4 commits into
Closed
Conversation
- Add libacl cc_library target in third_party/acl/BUILD for linux/aarch64
that links -lacl directly, replacing the external deb package dependency
- Update acl alias to select libacl on linux/aarch64 and Android paths
- Add missing load("@bazel_skylib//lib:selects.bzl", "selects") required
by selects.config_setting_group usage in the same file
Applies on top of v0.2.7 (cab36dd) for local Android GVM testing.
- score/memory/shared/map.h: guard Boost interprocess Map with !defined(__ANDROID__) since Android bionic does not support it - score/memory/shared/BUILD: add //conditions:default branch to select() to prevent unresolved select errors on Android platform - score/os/BUILD: extend acl deps to include Android platform; add shm_android fallback for shm_open/shm_unlink (bionic lacks these); make -lpthread conditional on non-Android (bionic includes pthread in libc) - third_party/acl/android/: Android-compatible ACL stub implementation - third_party/shm_android/: file-based shm_open/shm_unlink backed by /dev/shm tmpfs for Android GVM targets Required for score_baselibs to build cleanly on Android aarch64 GVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable support for Android platform