Fix dc and dp flag definitions to match GNU#1311
Merged
Steven Ramirez Rosa (Steven6798) merged 1 commit intoJun 19, 2026
Merged
Conversation
Replace incorrect "--dc" and "--dp" flags with GNU-standard "-dc" and "-dp". Fix: qualcomm#1310 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
Steven Ramirez Rosa (Steven6798)
requested review from
Shankar Easwaran (quic-seaswara) and
Shakti Suman (quic-shaksuma)
June 19, 2026 18:26
Shankar Easwaran (quic-seaswara)
approved these changes
Jun 19, 2026
Shakti Suman (quic-shaksuma)
approved these changes
Jun 19, 2026
Steven Ramirez Rosa (Steven6798)
merged commit Jun 19, 2026
6df7166
into
qualcomm:main
13 checks passed
Bhoumik Patidar (BhoumikPatidar)
added a commit
to BhoumikPatidar/eld
that referenced
this pull request
Jul 23, 2026
merged) PR qualcomm#1311 (scripts/cross-eld-x86_64.txt + scripts/do-eld-x86_64-configure) was merged into upstream picolibc. Use them directly instead of writing the cross file at CI time. Changes: - Add compiler-rt builtins path to x86_64 matrix picolibc-*-config fields (same pattern as hexagon/other backends) - Remove cross-file-writing block from Checkout Picolibc step - Replace manual meson setup invocations with ../scripts/do-eld-x86_64-configure, matching exactly how other backends use do-clang-X-configure - Simplify i386 wrapper step: remove eld-bdir symlink and ELD_BDIR export since the cross file now uses c_ld='eld' which clang resolves by finding ld.eld (our wrapper) directly in PATH The only remaining x86_64-specific code is the i386 wrapper step (ELD has no i386 backend; picolibc builds a 32-bit semihosting BIOS for QEMU). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Bhoumik Patidar (BhoumikPatidar)
added a commit
to BhoumikPatidar/eld
that referenced
this pull request
Jul 24, 2026
Adds x86_64-none-elf to the existing picolibc builder matrix, which already covers hexagon, aarch64, riscv64, riscv32, and arm. x86_64-specific setup: - Matrix entry with compiler-rt builtins path in picolibc-*-config fields, following the same pattern as other backends. - i386 linker wrapper: ELD has no i386 backend but picolibc builds a 32-bit semihosting BIOS for QEMU using elf_i386 emulation. A wrapper script is installed as ld.eld that routes i386 links to lld and all other links to the real ELD binary. - Build steps use ../scripts/do-eld-x86_64-configure from upstream picolibc (scripts/cross-eld-x86_64.txt + scripts/do-eld-x86_64-configure were added via picolibc PR qualcomm#1311). No manual cross file generation or meson setup workarounds needed. - qemu-system-x86 added to the apt-install for test execution. - export PATH to toolchain bin added to build and test run steps.
Bhoumik Patidar (BhoumikPatidar)
added a commit
to BhoumikPatidar/eld
that referenced
this pull request
Jul 24, 2026
Adds x86_64-none-elf to the existing picolibc builder matrix, which already covers hexagon, aarch64, riscv64, riscv32, and arm. x86_64-specific setup: - Matrix entry with compiler-rt builtins path in picolibc-*-config fields, following the same pattern as other backends. - i386 linker wrapper: ELD has no i386 backend but picolibc builds a 32-bit semihosting BIOS for QEMU using elf_i386 emulation. A wrapper script is installed as ld.eld that routes i386 links to lld and all other links to the real ELD binary. - Build steps use ../scripts/do-eld-x86_64-configure from upstream picolibc (scripts/cross-eld-x86_64.txt + scripts/do-eld-x86_64-configure were added via picolibc PR qualcomm#1311). No manual cross file generation or meson setup workarounds needed. - qemu-system-x86 added to the apt-install for test execution. - export PATH to toolchain bin added to build and test run steps. Signed-off-by: Bhoumik Patidar <bpatidar@qti.qualcomm.com>
Bhoumik Patidar (BhoumikPatidar)
added a commit
to BhoumikPatidar/eld
that referenced
this pull request
Jul 24, 2026
Adds x86_64-none-elf to the existing picolibc builder matrix, which already covers hexagon, aarch64, riscv64, riscv32, and arm. x86_64-specific setup: - Matrix entry with compiler-rt builtins path in picolibc-*-config fields, following the same pattern as other backends. - i386 linker wrapper: ELD has no i386 backend but picolibc builds a 32-bit semihosting BIOS for QEMU using elf_i386 emulation. A wrapper script is installed as ld.eld that routes i386 links to lld and all other links to the real ELD binary. - Build steps use ../scripts/do-eld-x86_64-configure from upstream picolibc (scripts/cross-eld-x86_64.txt + scripts/do-eld-x86_64-configure were added via picolibc PR qualcomm#1311). No manual cross file generation or meson setup workarounds needed. - qemu-system-x86 added to the apt-install for test execution. - export PATH to toolchain bin added to build and test run steps. Signed-off-by: Bhoumik Patidar <bpatidar@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace incorrect "--dc" and "--dp" flags with GNU-standard "-dc" and "-dp".
Fix: #1310