Skip to content

Harden design skill routing and token contracts - #9

Open
mosobande wants to merge 4 commits into
orifrom
fix/design-skill-system-cleanup
Open

Harden design skill routing and token contracts#9
mosobande wants to merge 4 commits into
orifrom
fix/design-skill-system-cleanup

Conversation

@mosobande

@mosobande mosobande commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Why

The design-skill system had overlapping ownership, stale helper claims, prohibited default-prompt metadata, and token contracts that did not match slide generation. These gaps could route focused work to the wrong owner, advertise behavior that helpers did not provide, or generate slides against an incomplete token source.

What changed

  • Add a minimum coding setup to README.md, and remove olofofo and salaye from Alarina routing.
  • Route single logo, corporate-identity, custom-icon, and non-banner social-system work to apere.
  • Remove default_prompt from all seven affected design-skill metadata files.
  • Separate ownership: banner-design owns constrained banner surfaces; apere owns its built-in visual modes; amoye-ui-ux recommends or reviews UI direction; asa-oju-ibanisoro owns React implementation.
  • Make Amoye reference loading conditional for native/mobile versus web/desktop work, and give conditional design references explicit loading paths.
  • Make documented Python commands use python3, align Brand and Banner claims with their helpers, and remove the unrelated canvas workflow.
  • Canonicalize generated token names, preserve aliases, and reject unresolved references, cycles, and CSS-name collisions.
  • Expand the starter token contract with Slides roles; require both project token artifacts; reject undefined variables before output; and replace hardcoded CTA colors with owned aliases.
  • Add a minor Changeset for the complete design-skill repair.

Critical contracts

  • Social ownership follows deliverable shape: banner surfaces route to banner-design; posts, carousels, stories, templates, and multi-format systems route to apere.
  • Bundled banner dimensions are starting defaults. Production work must verify the current platform requirement and record its source and date, or use a supplied specification.
  • eto-apere owns token declarations. slides consumes that contract and stops when a required artifact or referenced CSS variable is missing.
  • Token aliases remain var(--token) references. Canonical state naming puts the state last, such as --button-bg-hover.
  • The ASA helper targets Tailwind CSS 3 configuration. It accepts approved var(--token) color references and rejects raw CLI colors; Tailwind CSS 4 remains CSS-first through @theme.

Verification

  • Amoye data validation passed; its standard-library suite passed 39/39.
  • Slides regression suite passed 3/3, including empty-scope failure behavior.
  • Python syntax, CommonJS syntax, YAML metadata, Apere helper smoke checks, token-graph negative cases, token generation through slide validation, pre-write rejection cases, Brand token sync, Changesets, and diff checks passed on the original design candidate.
  • Two independent final Ko Skill reviews verified design commit 048865a.

Existing pytest-based Apere and Brand suites did not run because pytest is not installed. Their affected helpers received targeted syntax and smoke checks. No browser render, overflow, or visual contrast pass was run.

Current-base integration

Merge commits 4675cfd and 4bc6448 integrate the latest ori, including merged PR #14, without rewriting PR history. The only textual conflict was skills/alarina/SKILL.md; its resolution keeps PR #9's removal of olofofo and salaye routes while preserving the current seda-pr commit-and-push route.

Fresh proof on the merged head: Amoye 39/39, Slides 3/3, Seda 17/17, Wo 35/35, data validation, all 28 metadata files parsed, no prohibited default_prompt, no unsupported documented python invocation in the four affected skills, the single-deliverable Apere route is present, CLAUDE.md and README integration fixes remain present, Changesets reports the expected minor bump, and diff checks pass. The remote head read back as 4bc6448b3d4a6ff04d9166be66ba45e26320941d.

Review focus

  • Confirm the apere/banner-design and amoye-ui-ux/asa-oju-ibanisoro ownership boundaries.
  • Review canonical token-name mapping and alias validation in skills/eto-apere/scripts/generate-tokens.cjs.
  • Review the pre-write contract in skills/slides/scripts/generate-slide.py with undefined-variable enforcement in html-token-validator.py.
  • Confirm that the deleted canvas reference has no remaining consumer.
  • Confirm that the Alarina conflict resolution preserves both design routing and current Seda publication behavior.

Contribution map

  • Routing and catalog: README.md, skills/alarina, skills/apere, skills/banner-design.
  • Recommendation and brand contracts: skills/amoye-ui-ux, skills/brand.
  • UI implementation contract: skills/asa-oju-ibanisoro.
  • Token architecture and runtime: skills/eto-apere.
  • Slide generation and validation: skills/slides.
  • Release intent: .changeset/harden-design-skill-system.md.

@mosobande mosobande added bug Something isn't working documentation Improvements or additions to documentation labels Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant