Prevent implicit package search from top level setup.py #5330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top level setup.py is virtual and only declares cirq-core, cirq-google, and others as its dependencies. Make sure it does not search for packages, which would raise setuptools error. Resolves quantumlib#5291
drewrisinger
added a commit
to drewrisinger/nur-packages
that referenced
this pull request
May 5, 2022
Uses patch from quantumlib/Cirq#5330
dstrain115
approved these changes
May 6, 2022
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
) The top level setup.py is virtual and only declares cirq-core, cirq-google, and others as its dependencies. Make sure it does not search for packages, which would raise setuptools error. Resolves quantumlib#5291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level setup.py is virtual and only declares cirq-core,
cirq-google, and others as its dependencies.
Make sure it does not search for packages,
which would raise setuptools error.
Resolves #5291