Improve performance of _build_sweep_const #7601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Aug 23, 2025
dstrain115
commented
- This function was building the Const message twice.
- Instead, write directly to the proto message.
- This speeds up run contexts with Const values up by about 40%.
- This function was building the Const message twice. - Instead, write directly to the proto message. - This speeds up run contexts with Const values up by about 40%.
dstrain115
requested review from
a team,
verult,
vtomole and
wcourtney
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7601 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 1103 1103
Lines 99695 99683 -12
=======================================
- Hits 97209 97198 -11
+ Misses 2486 2485 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
reviewed
Aug 25, 2025
pavoljuhas
approved these changes
Aug 25, 2025
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a tiny suggestion.
Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
ddddddanni
pushed a commit
to ddddddanni/Cirq
that referenced
this pull request
Sep 1, 2025
- This function was building the Const message twice. - Instead, write directly to the proto message. - This speeds up run contexts with Const values up by about 40%. --------- Co-authored-by: Pavol Juhas <pavol.juhas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.