Skip to content

Conversation

@ToastCheng
Copy link
Contributor

@ToastCheng ToastCheng commented Sep 1, 2025

After adding the Cirq to OSS-Fuzz project list, we'll need to configure GitHub action to run the CI fuzzer. This PR basically follows https://google.github.io/oss-fuzz/getting-started/continuous-integration/ to enable the workflow.

Partially implements #7515

@ToastCheng ToastCheng requested review from a team and vtomole as code owners September 1, 2025 14:38
@ToastCheng ToastCheng requested a review from maffoo September 1, 2025 14:38
@github-actions github-actions bot added the size: S 10< lines changed <50 label Sep 1, 2025
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (f7a90c2) to head (b65f548).
⚠️ Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7625      +/-   ##
==========================================
- Coverage   97.50%   97.28%   -0.23%     
==========================================
  Files        1103     1107       +4     
  Lines       99665   102319    +2654     
==========================================
+ Hits        97179    99540    +2361     
- Misses       2486     2779     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for setting this up.

@pavoljuhas pavoljuhas enabled auto-merge November 13, 2025 20:07
@pavoljuhas pavoljuhas disabled auto-merge November 13, 2025 20:08
@ToastCheng
Copy link
Contributor Author

Hi @pavoljuhas! From my local test, the project name needs to be in lowercase, since it's used as a Docker image name, which has a lowercase restriction. I also updated my OSS-Fuzz commit accordingly, sorry about the confusion!

(running on OSS-Fuzz repo root)
python infra/helper.py shell Cirq
INFO:__main__:Running: docker build -t gcr.io/oss-fuzz/Cirq --file /usr/local/google/home/toastcheng/dev/qc/oss-fuzz/projects/Cirq/Dockerfile /usr/local/google/home/toastcheng/dev/qc/oss-fuzz/projects/Cirq.
[+] Building 0.0s (0/0)                                                                                                                                                                          docker:default
ERROR: failed to build: invalid tag "gcr.io/oss-fuzz/Cirq": repository name must be lowercase
ERROR:__main__:Docker build failed.

Note: this command is from OSS-Fuzz debugging doc

Change project name back to lowercase as it needs to work
as (lowercase-only) Docker image name.

Refs:

- quantumlib#7625 (comment)
- ToastCheng/oss-fuzz@7deb0b7

This reverts commit 31f8647.
@pavoljuhas pavoljuhas requested a review from mhucka November 25, 2025 02:22
@pavoljuhas
Copy link
Collaborator

Hi @pavoljuhas! From my local test, the project name needs to be in lowercase, since it's used as a Docker image name, which has a lowercase restriction. I also updated my OSS-Fuzz commit accordingly, sorry about the confusion!
...

Thank you for pointing this out! I have reverted back to the lowercase name.

On a side note, I have reassigned the review to @mhucka who has more domain knowledge with CI workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants