-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Optimize pauli_string_measurement_with_readout_mitigation_test #7740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Decrease count-like arguments of `measure_pauli_strings` from 1000 to 300 and increase the simulated readout errors so they can be estimated with fewer repetitions. Related to b/454743228
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7740 +/- ##
=======================================
Coverage 99.38% 99.38%
=======================================
Files 1091 1091
Lines 97912 97912
=======================================
Hits 97306 97306
Misses 606 606 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Here is a representative change of affected tests duration from check/pytest --numprocesses=0 --durations=0 \
cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation_test.pyBEFORE (21ee064) AFTER (e6e3736) |
ddddddanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little worried this would lead to more test failures, since we reduce the counts for pauli_repetitions and readout_repetitions. Otherwise looks good to me!
Ack. I ran a batch of 100 repeats of these tests with different pytest-randomly seeds which all passed fine. We can increase the counts or error tolerances if errors starts showing up on the CI. |

Decrease count-like arguments of
measure_pauli_stringsfrom 1000 to 300and increase the simulated readout errors so they can be estimated with
fewer repetitions.
Related to b/454743228