Skip to content

Conversation

@RahilJain1366
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the size: L 250< lines changed <1000 label Nov 7, 2025
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly there after few adjustments. Please see inline comments.

self._warning_shown = True


DEFAULT_CONTRIB_RESOLVERS = _DeprecatedDefaultContribResolvers()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use _compat.deprecate_attributes with a deadline of v1.8 instead - similarly as what was done for the XMON (and others) here -

_compat.deprecate_attributes(
__name__,
{
'XMON': ('v0.16', _SERIALIZABLE_GATESET_DEPRECATION_MESSAGE),
'FSIM_GATESET': ('v0.16', _SERIALIZABLE_GATESET_DEPRECATION_MESSAGE),
'SQRT_ISWAP_GATESET': ('v0.16', _SERIALIZABLE_GATESET_DEPRECATION_MESSAGE),
'SYC_GATESET': ('v0.16', _SERIALIZABLE_GATESET_DEPRECATION_MESSAGE),
'NAMED_GATESETS': ('v0.16', _SERIALIZABLE_GATESET_DEPRECATION_MESSAGE),
},
)

The deprecate_attributes call should be the last one in this module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavoljuhas

I have tried creating similar to the XMON example provided, can you please review the change and let me know if it is correct or is there any fix needed for the change?

I tried running a basic run with test code but since json_test.py has been removed, I wasn't able to confirm the warning message.

Comment on lines 30 to 32
# TODO: #7520 - create .json and .repr for these so they can be tested here
tested_elsewhere=["QuantumVolumeResult", "SwapPermutationGate", "BayesianNetworkGate"],
#tested_elsewhere=["QuantumVolumeResult", "SwapPermutationGate", "BayesianNetworkGate"],
tested_elsewhere=[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete, tested_elsewhere is an optional argument.
Also clean up the TODO comment, it would be confusing if left in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavoljuhas

I have removed tested_elsewhere from the spec.py file

@pavoljuhas pavoljuhas changed the base branch from v1.6.0-dev to main November 8, 2025 04:14
@pavoljuhas pavoljuhas changed the base branch from main to v1.6.0-dev November 8, 2025 04:15
@pavoljuhas
Copy link
Collaborator

pavoljuhas commented Nov 8, 2025

@RahilJain1366 - please update your PR to merge towards the main branch. The vX.Y.Z-dev branches are for releases only and should not be use for regular code development.

(If easier you can also close this PR, rebase your branch on main and submit as a new PR.

@RahilJain1366
Copy link
Contributor Author

@pavoljuhas

I have created a new PR (#7743) merging to the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants