Skip to content

Conversation

@pavoljuhas
Copy link
Collaborator

New ruff linter rules activated and fixed here:

  • useless-object-inheritance (UP004)
  • native-literals (UP018)
  • yield-in-for-loop (UP028)
  • extraneous-parentheses (UP034)
  • deprecated-import (UP035)

Partially implements #7505

@github-actions github-actions bot added the size: M 50< lines changed <250 label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (3e0e213) to head (b0d362f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7748    +/-   ##
========================================
  Coverage   99.38%   99.38%            
========================================
  Files        1090     1090            
  Lines       97920    98232   +312     
========================================
+ Hits        97314    97627   +313     
+ Misses        606      605     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pavoljuhas pavoljuhas requested a review from mhucka November 12, 2025 01:15
@pavoljuhas
Copy link
Collaborator Author

Sorry about the PR size. I'd recommend to review it commit-by-commit, the first 4 commits are small. The last commit is mostly a mechanical result from ruff check --select=UP035 --fix.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pavoljuhas pavoljuhas added this pull request to the merge queue Nov 12, 2025
Merged via the queue into quantumlib:main with commit ea7c94e Nov 12, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the ruff-activate-up-rules branch November 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants