Skip to content

Conversation

@pavoljuhas
Copy link
Collaborator

By default the GHA endpoint pulls/PULL_NUMBER/files retrieves
change data for up to 30 files which is insufficient for PRs that
touch more files. Here we increase the count to the maximum
per_page limit of 100.

It does not seem worthwhile to add pagination processing as
in the last year only 1% of PRs touched more than 100 files.

Ref: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests-files

By default the GHA endpoint `pulls/PULL_NUMBER/files` retrieves
change data for up to 30 files which is insufficient for PRs that
touch more files.  Here we increase the count to the maximum
per_page limit of 100.

It does not seem worthwhile to add pagination processing as
in the last year only 1% of PRs touched more than 100 files.

Ref: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-pull-requests-files
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners November 12, 2025 01:39
@github-actions github-actions bot added the Size: XS <10 lines changed label Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (3e0e213) to head (f6d69e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7749   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files        1090     1090           
  Lines       97920    97920           
=======================================
+ Hits        97314    97315    +1     
+ Misses        606      605    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added this pull request to the merge queue Nov 12, 2025
Merged via the queue into quantumlib:main with commit c444498 Nov 12, 2025
35 checks passed
@pavoljuhas pavoljuhas deleted the check-more-files-with-size-labeler branch November 12, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants