Skip to content

Conversation

@daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Nov 16, 2025

Update QasmUGate to handle parameterized values for theta, phi, and lmda.
Resolves #5983
Resolves #5985

@daxfohl daxfohl requested review from a team and vtomole as code owners November 16, 2025 06:05
@daxfohl daxfohl requested a review from maffoo November 16, 2025 06:05
@github-actions github-actions bot added the size: M 50< lines changed <250 label Nov 16, 2025
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.38%. Comparing base (ad37bb7) to head (e2c172f).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7759   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files        1090     1090           
  Lines       98248    98279   +31     
=======================================
+ Hits        97643    97674   +31     
  Misses        605      605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you for fixing this.

@pavoljuhas pavoljuhas added this pull request to the merge queue Nov 18, 2025
Merged via the queue into quantumlib:main with commit 82435c1 Nov 18, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update QasmUGate to support symbols in parameters. Support for Symbols in QasmUGate?

2 participants