Skip to content

Move .coveragerc contents to pyproject.toml#1281

Merged
mhucka merged 9 commits intoquantumlib:mainfrom
mhucka:move-coveragerc-to-pyproject
Apr 24, 2026
Merged

Move .coveragerc contents to pyproject.toml#1281
mhucka merged 9 commits intoquantumlib:mainfrom
mhucka:move-coveragerc-to-pyproject

Conversation

@mhucka
Copy link
Copy Markdown
Contributor

@mhucka mhucka commented Apr 23, 2026

Consolidate tool settings into pyproject.toml.

One of the PRs that will resolve #1268.

mhucka added 2 commits April 23, 2026 20:51
Consolidate tool settings into pyproject.toml.
Now that the options are in pyproject.toml, the explicit argument is no
longer necessary.
@mhucka
Copy link
Copy Markdown
Contributor Author

mhucka commented Apr 23, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the coverage configuration from a standalone file to pyproject.toml and updates the pytest-and-incremental-coverage script to reflect this change. A critical issue was identified in pyproject.toml where the [tool.coverage.run] table header is duplicated, which would result in a TOML parsing error.

Comment thread pyproject.toml
@mhucka mhucka marked this pull request as ready for review April 23, 2026 21:06
@mhucka mhucka requested review from mpharrigan and pavoljuhas April 23, 2026 21:06
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the coverage configuration from a standalone .coveragerc file to pyproject.toml. It updates the pytest-and-incremental-coverage script to remove the explicit configuration path and adds the corresponding omit rules to the pyproject.toml file. I have no feedback to provide as there were no review comments.

@mhucka mhucka added area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves code and/or project health labels Apr 23, 2026
@mhucka mhucka added this pull request to the merge queue Apr 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 23, 2026
@mhucka mhucka added this pull request to the merge queue Apr 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 24, 2026
@mhucka mhucka added this pull request to the merge queue Apr 24, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 24, 2026
@mhucka mhucka enabled auto-merge April 24, 2026 17:40
@mhucka mhucka added this pull request to the merge queue Apr 24, 2026
Merged via the queue into quantumlib:main with commit b30baca Apr 24, 2026
18 checks passed
@mhucka mhucka deleted the move-coveragerc-to-pyproject branch April 24, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops Involves build systems, Make files, Bazel files, continuous integration, and or other DevOps topics area/health Involves code and/or project health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tool configuration settings into pyproject.toml

2 participants