Skip to content

Added shellcheck dependency#1320

Merged
mhucka merged 1 commit into
quantumlib:mainfrom
arettig:shellcheck_dep
May 30, 2026
Merged

Added shellcheck dependency#1320
mhucka merged 1 commit into
quantumlib:mainfrom
arettig:shellcheck_dep

Conversation

@arettig
Copy link
Copy Markdown
Contributor

@arettig arettig commented May 30, 2026

Added shellcheck-py as a development dependency as it is used in check/shellcheck and the optional pre-commit hooks.

@arettig arettig requested a review from mhucka May 30, 2026 00:06
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds shellcheck-py as a development dependency. It introduces a new dependency file deps/shellcheck.txt, generates the corresponding environment lockfile envs/shellcheck.env.txt, updates the development environment lockfile envs/dev.env.txt, and registers the new environment recipe in run-pip-compiles.py. I have no feedback to provide as there are no review comments and the changes are straightforward.

Copy link
Copy Markdown
Collaborator

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and focused. Nice!

@mhucka mhucka added this pull request to the merge queue May 30, 2026
Merged via the queue into quantumlib:main with commit a51cdcc May 30, 2026
22 checks passed
@arettig arettig linked an issue May 30, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shellcheck dependency is not installed

2 participants