Builds & CI checks are failing due to fxpmath + setuptools 78

[mhucka]

Setuptools version 78.x (released approx 1 hour ago PST) enforces what was previously a warning about not using dashes in setup.cfg file property names. Unfortunately, the fxpmath package uses a dash in its setup.cfg files, and now CI and local builds are failing:

Collecting fxpmath==0.4.9 (from -r dev_tools/requirements/envs/pylint.env.txt (line 233))
  Downloading fxpmath-0.4.9.tar.gz (51 kB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [27 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
          main()
        File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main
          json_out["return_val"] = hook(**hook_input["kwargs"])
        File "/opt/hostedtoolcache/Python/3.10.16/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line [143](https://github.com/quantumlib/Qualtran/actions/runs/14038513411/job/39302502405?pr=1597#step:4:144), in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 334, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 304, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 522, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 320, in run_setup
          exec(code, locals())
        File "<string>", line 19, in <module>
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 116, in setup
          _install_setup_requires(attrs)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in _install_setup_requires
          dist.parse_config_files(ignore_option_errors=True)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 730, in parse_config_files
          self._parse_config_files(filenames=inifiles)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 599, in _parse_config_files
          opt = self._enforce_underscore(opt, section)
        File "/tmp/pip-build-env-b1qbq1ek/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 629, in _enforce_underscore
          raise InvalidConfigError(
      setuptools.errors.InvalidConfigError: Invalid dash-separated key 'description-file' in 'metadata' (setup.cfg), please use the underscore name 'description_file' instead.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

This may not be the only package that will fail to install. It just happens to be the first one that I hit while trying to do pip install -r dev_tools/requirements/envs/dev.env.txt.

(This was on MacOS 15.3.2 using Python 3.11.9.)

[mhucka]

I'm looking at the setuptools code involved, and it does not look like there's a way to ignore the error.

[mpharrigan]

So no one can install fxpmath? Am I understanding this correctly?

[mhucka]

As far as I can tell, yes. I've tried it in multiple environments, all with the same result, so I don't think the problem is specific to me (plus, it happens with the CI checks on GitHub).

> pyenv activate ttt
> pip list
Package Version
------- -------
pip     24.3.1
> pip install 'setuptools<78'
Collecting setuptools<78
  Using cached setuptools-77.0.3-py3-none-any.whl.metadata (6.6 kB)
Using cached setuptools-77.0.3-py3-none-any.whl (1.3 MB)
Installing collected packages: setuptools
Successfully installed setuptools-77.0.3
> pip list
Package    Version
---------- -------
pip        24.3.1
setuptools 77.0.3
> pip install fxpmath
Collecting fxpmath
  Using cached fxpmath-0.4.9.tar.gz (51 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1

[mhucka]

Issue tracker in the setuptools repo where people have been discussing this problem: pypa/setuptools#4910

[mhucka]

Setuptools version 78.0.2 has been released and it reverts the underlying behavior that caused these failures. C.f. pypa/setuptools#4911