Create controlled greater than bloq#1283
Merged
NoureldinYosri merged 8 commits intoAug 16, 2024
Merged
Conversation
Collaborator
|
Incidentally fixes #1230 |
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
reviewed
Aug 15, 2024
fdmalone
requested changes
Aug 15, 2024
Collaborator
fdmalone
left a comment
fdmalone
left a comment
There was a problem hiding this comment.
Some nits / questions.
Collaborator
|
Nice! |
fdmalone
approved these changes
Aug 16, 2024
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A controlled version of greater than is needed in order to be able to create controlled mod addition gate.
In this PR I create CLinearDepthGreaterThan and fix some classical and QDType bugs in other bloqs
I also update OnEach to accept a target dtype ... that's because OnEach returns a register of type QAny which causes problems in classical simulation. this way we can expect maintain the dtype of the input register.
I updated #1278 so that it tracks all .controlled work