Use XorK bloq instead of CNOTs to load data in QROM#1335
Merged
tanujkhattar merged 3 commits intoquantumlib:mainfrom Aug 22, 2024
Merged
Use XorK bloq instead of CNOTs to load data in QROM#1335tanujkhattar merged 3 commits intoquantumlib:mainfrom
tanujkhattar merged 3 commits intoquantumlib:mainfrom
Conversation
Collaborator
|
NIIIICE |
fdmalone
reviewed
Aug 22, 2024
| yield XorK(QUInt(target_bitsize), data_to_load).on(*target[idx]).controlled_by( | ||
| *ctrl_qubits | ||
| ) | ||
| # for q, bit in zip(target[idx], f'{data_to_load:0{target_bitsize}b}'): |
Collaborator
There was a problem hiding this comment.
remove commented out code? OR say equivalent to if it's helpful for readability
Collaborator
Author
There was a problem hiding this comment.
Had to remove, forgot. Had commented out assuming there would be test failures that I may need to go and debug; fortunately; there were no test failures :)
fdmalone
approved these changes
Aug 22, 2024
Collaborator
|
niiiice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the readability of the decomposition and reduces the number of subbloqs in the resulting composite bloq. Should also help with #1052
See old and new diagrams generated by the following test code
Old Diagram:
New Diagram:
