Fix selection_registers in qubitization_walk_test#1350
Merged
charlesyuan314 merged 1 commit intoquantumlib:mainfrom Aug 27, 2024
Merged
Fix selection_registers in qubitization_walk_test#1350charlesyuan314 merged 1 commit intoquantumlib:mainfrom
selection_registers in qubitization_walk_test#1350charlesyuan314 merged 1 commit intoquantumlib:mainfrom
Conversation
Contributor
Author
|
@fdmalone Would it make sense to add a non-slow test that catches the same behavior as the failing slow test? |
fdmalone
approved these changes
Aug 27, 2024
Collaborator
|
hmmm in this case I think this is a vestige of an older qualtran (returning a Signature and not a tuple of Registers). I'm not sure what we would be testing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a typing problem that is causing the nightly tests to fail.