fix QPE test failure, add non-slow bloq example autotest#1487
Merged
fdmalone merged 5 commits intoquantumlib:mainfrom Nov 7, 2024
Merged
fix QPE test failure, add non-slow bloq example autotest#1487fdmalone merged 5 commits intoquantumlib:mainfrom
fdmalone merged 5 commits intoquantumlib:mainfrom
Conversation
anurudhp
force-pushed
the
2024/11/06-fix-qpe-tests
branch
from
62ea110 to
9cb2e5e
Compare
Contributor
Author
|
@mpharrigan @fdmalone ptal! |
fdmalone
reviewed
Nov 7, 2024
fdmalone
approved these changes
Nov 7, 2024
Collaborator
fdmalone
left a comment
fdmalone
left a comment
There was a problem hiding this comment.
LGTM % nit about this silent exception
Collaborator
|
LGTM |
Contributor
Author
|
could you merge it? (I don't have the permissions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One set of tests failed due to a signature mismatch: now added a fast bloq example test for QubitizationQPE
Another was simulation: fixed by defaulting to tensor if cirq unitary fails for controlled bloqs.