Conversation
- Upgrades sympy and fixes typechecking issues that result.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| ignore_missing_imports = true | ||
|
|
||
| [mypy-sympy.*] | ||
| follow_untyped_imports = True |
There was a problem hiding this comment.
did you notice any effect on the typechecking runtime?
There was a problem hiding this comment.
I saw less mypy errors (it was like 12 versus 24 without this). I didn't really investigate it though.
| @@ -1,5 +1,5 @@ | |||
| # | |||
| # This file is autogenerated by pip-compile with Python 3.10 | |||
| # This file is autogenerated by pip-compile with Python 3.12 | |||
There was a problem hiding this comment.
since the pinned requirements are very delicate w.r.t. exactly which python environment you run them from, we use the ..from_docker.sh script to bump the dependencies from the included docker image. As an example, you can see that your name is now forever immortalized in the requirements comments.
I'll run the script and push to this pr to save you some time
There was a problem hiding this comment.
Thanks! I just ran the update deps script in this directory. Thanks for running it correctly for me!
|
wooooooooooo |
mpharrigan
added
the
devops
2 participants
Fixes: #1646