Split up datatype definition modules#1835
Merged
mpharrigan merged 1 commit intoquantumlib:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the quantum data type definitions by moving them from a monolithic file in qualtran/_infra/data_types.py to a new modular package structure under qualtran/dtype. The changes include splitting the types into specialized modules (e.g., _int.py, _fxp.py, _uint.py) and adding comprehensive unit tests for each. A potential issue was identified in the new testing.py utility where the reshape operation may fail when handling symbolic data types, as numpy cannot process symbolic dimensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long overdue.
qualtran.dtype.XXXaliases for QCDTypes (the data type classes and objects used in your quantum programs)qualtran._infra.dtypeimports into aliasesqualtran.XXXre-exports anyways, which remain unchanged.This is just moving code. The only "change" is moving the assert_to_bits test helper is now in the public API.