More improvements to QVR Bloqs and their analysis#875
Merged
tanujkhattar merged 5 commits intoquantumlib:mainfrom May 9, 2024
Merged
More improvements to QVR Bloqs and their analysis#875tanujkhattar merged 5 commits intoquantumlib:mainfrom
tanujkhattar merged 5 commits intoquantumlib:mainfrom
Conversation
…asing_via_addition_analysis
mpharrigan
approved these changes
May 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few more improvements to QVR bloqs and their analysis notebook and documentation. Specifically, we now take into consideration the asymptotic improvement in$\epsilon$ .
QvrZPowdue to ignoring small angle rotations in order to synthesize rotations upto accuracyThis leads to this updated plot where you can now see that for a given accuracy$eps = 1e-12$ , $n$ . This is because once $n$ becomes large enough, we can truncate small angle rotations
QvrZPowasymptotes at a specific cost instead of continuing to scale with