Rename RandomGate -> MatrixGate#897
Merged
mpharrigan merged 1 commit intoquantumlib:mainfrom Apr 26, 2024
Merged
Conversation
anurudhp
force-pushed
the
2024-04-refactor-matrix-gate
branch
from
be0aba9 to
3dc0662
Compare
Collaborator
|
can you resolve merge conflicts, then I'll merge this in |
anurudhp
force-pushed
the
2024-04-refactor-matrix-gate
branch
from
3dc0662 to
f7104de
Compare
Contributor
Author
|
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name
RandomGatedoesn't make sense because we can instantiate with a matrix of choice as well.This also renames
RandomGate.create(...)->MatrixGate.random(...)which makes more sense.@mpharrigan @tanujkhattar PTAL