Changed controlled attribute to is_controlled#916
Merged
dstrain115 merged 1 commit intoquantumlib:mainfrom May 2, 2024
Merged
Conversation
Contributor
dstrain115
commented
May 1, 2024
dstrain115
commented
- Change controlled attribute to is_controlled or controlled_by.
- This attribute shadows the controlled() function inherited by GateWithRegisters which is confusing and type-unsafe.
- Change controlled attribute to is_controlled or controlled_by. - This attribute shadows the controlled() function inherited by GateWithRegisters which is confusing and type-unsafe.
mpharrigan
approved these changes
May 2, 2024
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
we usually use the term "control_value" or "cvs" but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.