Skip to content

Improve wire symbol testing#928

Merged
mpharrigan merged 1 commit intoquantumlib:mainfrom
dstrain115:fix_wire_symbol_testing
May 7, 2024
Merged

Improve wire symbol testing#928
mpharrigan merged 1 commit intoquantumlib:mainfrom
dstrain115:fix_wire_symbol_testing

Conversation

@dstrain115
Copy link
Copy Markdown
Contributor

@dstrain115 dstrain115 commented May 7, 2024

  • Allow wire symbol testing to accept non-trivial shapes (multi-dimensional registers)
  • Allow wire symbol testing to accept WireSymbols without text
  • Add wire symbol testing to Toffoli()

Fixes: #608

@dstrain115
Improve wire symbol testing
04bb151 
- Allow wire symbol testing to accept non-trivial shapes
(multi-dimensional registers)
- Allow wire symbol testing to accept WireSymbols without text
- Add wire symbol testing to Toffoli()

Fixes: quantumlib#608
@dstrain115 dstrain115 requested review from fdmalone and mpharrigan May 7, 2024 22:28
mpharrigan
mpharrigan approved these changes May 7, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@mpharrigan mpharrigan merged commit 54bc181 into quantumlib:main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

@fdmalone fdmalone Awaiting requested review from fdmalone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better wire symbol testing

2 participants

@dstrain115 @mpharrigan