[WIP] Use block encoding bloqs for all chemistry hamiltonians#998
[WIP] Use block encoding bloqs for all chemistry hamiltonians#998fdmalone wants to merge 11 commits intoquantumlib:mainfrom
Conversation
|
Seems like the right thing to do! Also +1 to break into smaller PRs if its not too much work. Do you want me to leave a detailed review now or are you still working on it? Also, I'm starting to work on a PR that organises |
|
You don't need to review now, just saw the organizational PR and didn't want a conflict with reflection. I didn't do anything special when moving the files though. |
|
Yeah I can wait to resolve conflicts which should be minor. Should we reorganize reflection first too? |
Yes, although I'm not sure where to best put the "reflection" bloq -- my suggestion is to create a new My suggestion is purely based on the aesthetics that we have Reflection is used commonly in many applications; so it doesn't feel right it to put it under any specific one like |
|
I can do this. I don't need octopus right, that's only for splitting up files? |
Yes, that's right. |
|
This was completed in chunks |
I might need to split this but given #997 I thought it better to open now to avoid any conflicts:
cc @tanujkhattar WDYT