Need explicitly set pypi user to __token__ if not passing a value
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way GitHub Actions workflows treat undefined variables combined with the way parameters are interpreted by `pypa/gh-action-pypi-publish` results in that action _not_ using its internal default (which actually is `__token__`) if the parameter expands to an empty string. My local testing did not reveal this because in local testing, I always assigned a value to `testpypi_user`.
mhucka
changed the title
__token__ if not passing a value__token__ if not passing a value
This is more secure than using environment variables for the testpypi user name and password.
mhucka
added
the
devops
Strilanc
approved these changes
Nov 10, 2025
mhucka
added a commit
that referenced
this pull request
Dec 1, 2025
) The way GitHub Actions workflows treat undefined variables combined with the way parameters are interpreted by `pypa/gh-action-pypi-publish` results in that action _not_ using its internal default (which actually is `__token__`) if the parameter expands to an empty string. My local testing did not reveal this because in local testing, I always assigned a value to `testpypi_user`. Also included in this PR is a clarification in the workflows/README.md file to one of the debugging tips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way GitHub Actions workflows treat undefined variables combined with the way parameters are interpreted by
pypa/gh-action-pypi-publishresults in that action not using its internal default (which actually is__token__) if the parameter expands to an empty string. My local testing did not reveal this because in local testing, I always assigned a value totestpypi_user.Also included in this PR is a clarification in the workflows/README.md file to one of the debugging tips.