Document NumPy 1 interaction with max simulation size#1015
Merged
mhucka merged 5 commits intoquantumlib:mainfrom Apr 6, 2026
Merged
Document NumPy 1 interaction with max simulation size#1015mhucka merged 5 commits intoquantumlib:mainfrom
mhucka merged 5 commits intoquantumlib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a helpful note to the documentation regarding issues with NumPy 1.26 in large simulations, recommending an upgrade to version 2.x. However, this creates a conflict with the requirements.txt file, which still permits the installation of NumPy 1.26. My review includes a comment to address this inconsistency to prevent potential issues for users.
mhucka
requested changes
Apr 5, 2026
Collaborator
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
Thank you for this contribution. Please see the suggested edits in the review. If you are satisfied with the suggestions, you can use GitHub's feature for accepting edits directly, to make it easier to amend the PR.
Co-authored-by: Michael Hucka <mhucka@google.com>
Co-authored-by: Michael Hucka <mhucka@google.com>
mhucka
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #863.